Open
Conversation
Contributor
|
Please ensure your branch is up to date with the master branch. |
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
=======================================
Coverage 92.09% 92.09%
=======================================
Files 6 6
Lines 253 253
=======================================
Hits 233 233
Misses 20 20 |
enpuyou
suggested changes
Apr 28, 2021
Contributor
enpuyou
left a comment
enpuyou
left a comment
There was a problem hiding this comment.
An overall comment, can you give us an example of what the JSON files would look like for the summary and frequencies? Thank you!
| if record: | ||
| # Write the summary into a json file. | ||
| data = sz.summarizer(directory) | ||
| file = open(path + "/" + record + ".json", "w") |
Contributor
There was a problem hiding this comment.
us os.path.sep instead of /
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A command-line interface feature has been added. This allows user to run the summary and word frequency function on the terminal and save the results on a .json file. The user can choose whether they want to save the results or have them printed on the terminal, the files will be kept in a separate folder.
What is the current behavior?
#34
What is the new behavior if this PR is merged?
Users should be able to run textmining.py, where the CLI is contained.
Type of change
Please describe the pull request as one of the following:
Other information
This PR has:
Developers
@nguyenmail and @cookaa