Fixes for implicit type vars and datatype decls in smt-lib#254
Merged
Conversation
Two fixes: - do not create an instance of an implicit type variable when checking whether something is shadowed. Otherwise, that instance might be wrongly assumed to be used, and in the case of a datatype declaration that does not allow implicit type variables, this will raise a spurious error - in datatype declarations, only explicit type variables are allowed, which was already correctly handled, but a shadowing warning was still emitted when one of the explicit type variables had the same name as one of the implicit one. In this case, there is no need for the warning as the implicit type variable cannot be used
936a3c5 to
1f7d8ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes:
This will close #253