Skip to content

fix: add zh to zh_CN mapping #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GeekyEggo merged 1 commit into from
Mar 21, 2025
Merged

fix: add zh to zh_CN mapping #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/core/__tests__/i18n.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,17 @@ describe("i18n", () => {
// then.
expect(i18n.language).toBe("zh_CN");
});

it("should map to simplified Chinese without region", async () => {
// given.
jest.spyOn(window.navigator, "language", "get").mockReturnValue("zh");

// when
const i18n = (await import("../i18n")).default;

// then.
expect(i18n.language).toBe("zh_CN");
});
});
});

Expand Down
2 changes: 1 addition & 1 deletion src/core/i18n.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export class Internationalization {
}

// Chinese Simplified
if (language === "zh-Hans" || language === "zh-CN") {
if (language === "zh" || language === "zh-Hans" || language === "zh-CN") {
return "zh_CN";
}

Expand Down