Skip to content

Fixed regression of false warning message #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gemba merged 1 commit into from
Sep 21, 2025
Merged

Fixed regression of false warning message #177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 17 additions & 14 deletions src/skyscraper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1290,17 +1290,19 @@ void Skyscraper::prepareIgdb(NetComm &netComm, QEventLoop &q) {
void Skyscraper::prepareScreenscraper(NetComm &netComm, QEventLoop &q) {
const int threadsFailsafe = 1; // Don't change! This limit was set by
// request from ScreenScraper
if ((config.user.isEmpty() || config.password.isEmpty()) &&
config.threads > 1) {
config.threads = threadsFailsafe;
printf("\033[1;33mForcing %d thread as this is the anonymous "
"limit in the ScreenScraper scraping module. Sign up for "
"an account at https://www.screenscraper.fr and support "
"them to gain more threads. Then use the credentials with "
"Skyscraper using the '-u user:password' command line "
"option or by setting 'userCreds=\"user:password\"' in "
"'%s/config.ini'.\033[0m\n\n",
config.threads, Config::getSkyFolder().toStdString().c_str());
if (config.user.isEmpty() || config.password.isEmpty()) {
if (config.threads > 1) {
config.threads = threadsFailsafe;
printf("\033[1;33mForcing %d thread as this is the anonymous "
"limit in the ScreenScraper scraping module. Sign up for "
"an account at https://www.screenscraper.fr and support "
"them to gain more threads. Then use the credentials with "
"Skyscraper using the '-u user:password' command line "
"option or by setting 'userCreds=\"user:password\"' in "
"'%s/config.ini'.\033[0m\n\n",
config.threads,
Config::getSkyFolder().toStdString().c_str());
}
} else {
printf("Fetching limits for user '\033[1;33m%s\033[0m', just a "
"sec...\n",
Expand Down Expand Up @@ -1341,12 +1343,13 @@ void Skyscraper::prepareScreenscraper(NetComm &netComm, QEventLoop &q) {
if (allowedThreads != 0) {
if (config.threadsSet && config.threads <= allowedThreads) {
printf("User is allowed %d threads, but user has set "
"it manually, so ignoring.\n\n",
allowedThreads);
"it manually to %d, using the latter value.\n\n",
allowedThreads, config.threads);
} else {
config.threads = (allowedThreads <= 8 ? allowedThreads : 8);
printf("Setting threads to \033[1;32m%d\033[0m as "
"allowed for the supplied user credentials.\n\n",
"allowed for the authenticated Screenscraper "
"account.\n\n",
config.threads);
}
}
Expand Down
Loading