Kickall by Mickey42302 · Pull Request #943 · GemstoneGG/Velocity-CTD

Mickey42302 · 2026-06-02T22:21:38Z

I would like to suggest the addition of a new command for Velocity-CTD: "/gkickall".

The "/gkickall" command would provide a way to easily kick all players from anywhere on the network. I've also included a bypass permission node: "velocity.command.gkickall.bypass"

R00tB33rMan

Only suggestion from me (for now): revert this back due to checkstyle to individual imports

Mickey42302 · 2026-06-02T23:20:51Z

The imports in VelocityServer should be updated now.

R00tB33rMan · 2026-06-03T00:06:39Z

The imports in VelocityServer should be updated now.

(Refer to our /send, /glist, & /plist commands). Can you implement something a bit more like this? I feel like it'd match up better with our current conventions and would allow the /gkick command to be more customizable. This'd supply kicking a specific player, all players, all players on a specific server, all players on a specific proxy, & corresponding cases

WouterGritter

I would rather make the /gkick command support PlayerIdentifier args like all the other CTD commands instead of introducing a new command for this. That would keep it aligned with all orher commands.

That would allow you to execute /gkick all, /gkick +server and /gkick -proxy for free, as PlayerIdentifier already implements this functionality for commands. Of course check this newly introduced permission before actually kicking each player.

WouterGritter · 2026-06-03T03:30:49Z

Also make sure to document the permission in README

WouterGritter

Still requesting changes, as per my previous comment, this functionality is better suited to be a part of /gkick. Allowing this existing command to support player identifiers aligns it with all other CTD commands that can perform actions on one player or a group of players, unless you have a good reason why you want this to be a separate command instead?

Mickey42302 · 2026-06-07T22:20:53Z

I'm working on the changes to the "/gkick" command. I've been having seizures again, so there may be a delay. I simply added the permission nodes to the README in the meantime until the updated code for "/gkick" is ready.

WouterGritter · 2026-06-08T14:50:09Z

I'm working on the changes to the "/gkick" command. I've been having seizures again, so there may be a delay. I simply added the permission nodes to the README in the meantime until the updated code for "/gkick" is ready.

Not an issue at all of course! Wishing you good health, and take your time.

…kAllCommand.java

Removed GkickAllCommand registration from VelocityServer.

Removed gkickall command functionality and related checks.

Mickey42302 · 2026-06-17T00:37:01Z

I've removed the original "/kickall" command and updated the code for "/gkick". Is this what you're looking for, or are more changes needed?

WouterGritter

The current approach deviates from other commands that accept "all", "specific server", "specific proxy" and "specific player". /alert and /transfer to name a few make use of our helper class PlayerIdentifier that computes the target(s) from a string like all, +<server> -<proxy> or <player>. This avoids having the second argument (e.g. /gkick server cool_server would become /gkick +cool_server), and works elegantly with the suggestionsprovider PlayerIdentifier already exposes:

To get his feature merged it really needs to be aligned with the other commands and make use of PlayerIdentifier internally, not only to make the command arguments work the same as the other commands, but also to avoid duplicate code.

Currently /gkick Notch would break here, you would need to type /gkick player Notch. messages.properties on existing Velocity-CTD setups don't migrate, meaning they will see the old usage message (/gkick <player> [reason]). This could be misleading if this stops working, though luckily refactoring to use PlayerIdentifier will make this work again.

WouterGritter · 2026-06-17T10:16:13Z

 velocity.command.find.usage=<red>/<arg:0> <player>
 velocity.command.find.message=<red><arg:0> <white>is currently connected to <red><arg:1><white>.
-velocity.command.gkick.usage=<red>/<arg:0> <player> [reason]
+velocity.command.gkick.usage=<red>Usage: /<arg:0> <all|server|player> <target> [reason]


Adding Usage: makes this usage string unique to all other usage strings. Let's keep this aligned with all others for now (drop Usage: ), if we want to add this prefix this is something for another PR and should be done for all similar strings.

WouterGritter · 2026-06-17T10:17:12Z

    return SINGLE_SUCCESS;
  }
-}
+}


Formatting (re-introduce newline)

WouterGritter · 2026-06-17T10:18:38Z

-            .arguments(Argument.string("0", player.getUsername()))
+    source.sendMessage(
+            Component.translatable("velocity.command.gkick.message")
+                    .arguments(Argument.string("0", player.getUsername()))


Please reformat the entire file with a continuation indent of 4 instead of 8. Here it's most visible in the diff but the continuation indentation is wrong in the entire class.

WouterGritter · 2026-06-17T10:19:13Z


 /**
- * Implements Velocity-CTD's {@code /gkick} command.
+ * Implements Velocity-CTD's flexible {@code /gkick} command.


I'd drop the flexible wording, we don't have this anywhere else.

WouterGritter · 2026-06-17T10:32:38Z

+    for (VelocityClusterPlayer player : targets) {
+      if (bypassPermission != null) {
+        boolean bypass = server.getPlayer(player.getUniqueId())
+                .map(nativePlayer -> nativePlayer.hasPermission(bypassPermission))


This permission check won't work on remote players in a proxy cluster setup. This will require ClusterPlayer to expose a new flag (isBypassGkick), and to wire the redis system to store this in PlayerEntry

WouterGritter · 2026-06-17T10:33:32Z

+    RequiredArgumentBuilder<CommandSource, String> serverNameNode =
+            BrigadierCommand.requiredArgumentBuilder("name", StringArgumentType.word())
+                    .suggests((ctx, builder) -> {
+                      for (com.velocitypowered.api.proxy.server.RegisteredServer registeredServer : server.getAllServers()) {


Formatting (use of FQDN while its imported)

WouterGritter · 2026-06-17T10:34:35Z

+    Optional<RegisteredServer> registeredServer = server.getServer(serverName)
+            .map(RegisteredServer.class::cast);
+
+    if (registeredServer.isEmpty()) {


No need to cast the result of server.getServer at line 143 just to check isEmpty(), these 3 lines can be condensed to a single if (server.getServer(serverName).isEmpty())

Mickey42302 · 2026-06-18T19:28:16Z

Is this code for "/gkick" better?

R00tB33rMan · 2026-06-19T13:48:48Z

This has been cleanly resolved in: #971 - I appreciate the effort; however, there are a lot of oddities that weren't properly addressed here. I appreciate the contribution but this has been resolved!

Mickey42302 added 7 commits June 2, 2026 18:15

Refactor command imports and register GkickAllCommand

221e1f8

Add gkickall command configuration and methods

afe7ef0

Add messages for gkickall command in messages.properties

4a0b6de

Add /gkickall command to README

3c6f8a8

Add files via upload

ec25f9f

Add message for no players to kick in messages.properties

536f2a9

Change kick message to use translatable component

54aa020

R00tB33rMan requested changes Jun 2, 2026

View reviewed changes

Refactor imports in VelocityServer.java

518ab66

WouterGritter requested changes Jun 3, 2026

View reviewed changes

Mickey42302 added 2 commits June 5, 2026 19:15

Merge branch 'GemstoneGG:libdeflate' into kickall

4c56ca6

Update README.md

5009955

WouterGritter requested changes Jun 7, 2026

View reviewed changes

Merge branch 'GemstoneGG:libdeflate' into kickall

3e28137

Mickey42302 added 8 commits June 12, 2026 12:55

Merge branch 'GemstoneGG:libdeflate' into kickall

3108709

Merge branch 'GemstoneGG:libdeflate' into kickall

33bfc7e

Delete proxy/src/main/java/com/velocityctd/proxy/command/builtin/Gkic…

d8ab287

…kAllCommand.java

Add files via upload

1293972

Update README.md

c3fb808

Update gkick command usage and messages

78da97a

Remove GkickAllCommand registration

ddad527

Removed GkickAllCommand registration from VelocityServer.

Remove gkickall command support

96df134

Removed gkickall command functionality and related checks.

WouterGritter requested changes Jun 17, 2026

View reviewed changes

WouterGritter reviewed Jun 17, 2026

View reviewed changes

R00tB33rMan mentioned this pull request Jun 17, 2026

Expand gkick to PlayerIdentifier + VelocityClusterPlayer #971

Merged

Mickey42302 added 4 commits June 18, 2026 12:30

Merge branch 'GemstoneGG:libdeflate' into kickall

babe3a0

Update README.md

5492bf2

Update gkick command usage and messages

62a2326

Add files via upload

b90d718

Merge branch 'GemstoneGG:libdeflate' into kickall

63e8749

R00tB33rMan closed this in #971 Jun 19, 2026

Mickey42302 deleted the kickall branch June 19, 2026 14:14

Uh oh!

Conversation

Mickey42302 commented Jun 2, 2026

Uh oh!

R00tB33rMan left a comment

Choose a reason for hiding this comment

Uh oh!

Mickey42302 commented Jun 2, 2026

Uh oh!

R00tB33rMan commented Jun 3, 2026

Uh oh!

WouterGritter left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WouterGritter commented Jun 3, 2026

Uh oh!

WouterGritter left a comment

Choose a reason for hiding this comment

Uh oh!

Mickey42302 commented Jun 7, 2026

Uh oh!

WouterGritter commented Jun 8, 2026

Uh oh!

Mickey42302 commented Jun 17, 2026

Uh oh!

WouterGritter left a comment

Choose a reason for hiding this comment

Uh oh!

WouterGritter Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

WouterGritter Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

WouterGritter Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

WouterGritter Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

WouterGritter Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

WouterGritter Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

WouterGritter Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

Mickey42302 commented Jun 18, 2026

Uh oh!

R00tB33rMan commented Jun 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

WouterGritter left a comment •

edited

Loading