Complex sample players placeholders for server list ping#969
Merged
Conversation
…stitue` with support for escaping and `Resolver` arguments
…motd hover and version name
…icException / IllegalArgumentException
R00tB33rMan
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces more complex sample player placeholders and the required parsing plumbing for this.
Example of what's possible to use for
motd,motd-hoverandfallback-version-ping:where:
max-> the maximum amount of players to showmaxPerLine-> the maximum amount of players to show per lineordering-> how to order the players:RANDOM-> random shuffle (Notchian behavior)ALPHABETICAL-> A-Z (player name)ALPHABETICAL_REVERSED-> Z-A (player name)LAST_JOINED-> most recent joins firstFIRST_JOINED-> oldest joins firstempty-> what to show when no (0) players are onlineprefix-> the prefix to append before each player nameseparator-> the separator between every two player names (trimmed on line end)Players are pooled meaning, players won't show up twice. This makes it possible to show the last player that joined, and a random list of all other online players, without this first player showing up in the random list. Example:
Would show the following MOTD hover:
motdin the config may now also be a string list (similar tomotd-hover).TODO:
isClientListingAllowed)motd+motd-hover+fallback-version-pingor have one pool per sectionsample-players-in-ping(be smart about this: populatemotd-hoverbased on if this was true/false to avoid changing behavior){players}behavior + argument examplesmotdto a string list)Example of the PR in action:
