feat(silo): allow updating of string columns - #1392
Merged
Merged
Conversation
Contributor
|
This is a preview of the changelog of the next release. If this branch is not up-to-date with the current main branch, the changelog may not be accurate. Rebase your branch on the main branch to get the most accurate changelog. Note that this might contain changes that are on main, but not yet released. Changelog: 0.13.0 (2026-07-28)⚠ BREAKING CHANGES
Features |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds missing update support for all string-column implementations so SaneQL/Python update_column can reassign plain, indexed, and zstd-compressed string fields (with explicit rejections for phylo-tree and lineage-index backed columns).
Changes:
- Implement
update(row_ids, optional<string>)forStringColumn,IndexedStringColumn, andZstdCompressedStringColumn. - Extend scalar update dispatch to allow string updates and add targeted rejection errors for phylo/lineage-backed columns.
- Add/extend C++ + Python tests and update Python binding documentation to reflect string update support.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/silo/storage/column/zstd_compressed_string_column.test.cpp | Adds unit test verifying update overwrites values (and nullability) across chunks. |
| src/silo/storage/column/zstd_compressed_string_column.h | Exposes update(...) API for zstd-compressed string columns. |
| src/silo/storage/column/zstd_compressed_string_column.cpp | Implements zstd-compressed string updates + null bitmap maintenance. |
| src/silo/storage/column/string_column.test.cpp | Adds unit test verifying chunk rebuild behavior and null toggling on update. |
| src/silo/storage/column/string_column.h | Updates chunk immutability doc and exposes update(...) API for plain string columns. |
| src/silo/storage/column/string_column.cpp | Implements chunk-rebuild-based updates for plain string columns. |
| src/silo/storage/column/indexed_string_column.test.cpp | Adds unit test ensuring updates keep inverted index consistent and handle null transitions. |
| src/silo/storage/column/indexed_string_column.h | Exposes update(...) API for indexed string columns. |
| src/silo/storage/column/indexed_string_column.cpp | Implements indexed-string updates while maintaining dictionary + inverted index + null bitmap. |
| src/silo/query_engine/scalar_column_update.cpp | Enables scalar updates for string types and adds explicit rejection messages for phylo/lineage-backed columns. |
| src/silo/database.test.cpp | Adds DB-level coverage for updating indexed string columns (including null and new dictionary values). |
| python/tests/test_database.py | Adds end-to-end Python tests for updating a plain string column via bindings. |
| python/silodb/database.pyx | Updates docstring to include quoted string literals + supported column types/rejections. |
| documentation/python_bindings.md | Updates user docs for update_column to include string updates and restrictions. |
fengelniederhammer
approved these changes
Jul 28, 2026
taepper
force-pushed
the
1389-update-string-columns
branch
from
July 28, 2026 12:46
b781b80 to
9307e36
Compare
taepper
force-pushed
the
1389-update-string-columns
branch
from
July 28, 2026 15:07
9307e36 to
4d7c561
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1389
Summary
This adds the missing
updatemethod to the three types of string columnsPR Checklist