fix: missing initialization of uint32_t in config struct. Set default value in ConfigSpecification instead. - #812
Merged
Merged
Conversation
… value in ConfigSpecification instead.
Contributor
|
This is a preview of the changelog of the next release. If this branch is not up-to-date with the current main branch, the changelog may not be accurate. Rebase your branch on the main branch to get the most accurate changelog. Note that this might contain changes that are on main, but not yet released. Changelog: 0.7.0 (2025-06-18)⚠ BREAKING CHANGES
Features
Bug Fixes
Code Refactoring |
fengelniederhammer
approved these changes
Jun 18, 2025
This was referenced Jun 18, 2025
Merged
This was referenced Jun 26, 2025
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The struct did not initialize the field, therefore it contained random bytes, when no value was given. I talked with Chaoran and we think setting it to 0 by default is best for users. (no need for configuration in e.g. Loculus)
PR Checklist