Skip to content

feat(website): make error tooltip direction configurable in AdvancedQueryFilter #1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fhennig merged 2 commits into from
May 14, 2026
Merged

feat(website): make error tooltip direction configurable in AdvancedQueryFilter #1204

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b551d2
feat(website): make error tooltip direction configurable in AdvancedQ…
fhennig May 8, 2026
14bfcb7
format
fhennig May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions website/src/components/genspectrum/AdvancedQueryFilter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,23 @@ type AdvancedQueryFilterProps = {
onInput?: (newValue: string | undefined) => void;
enabled: boolean;
lapisUrl: string;
/**
* Tailwind classes controlling the direction of the validation error tooltip.
* Defaults to `'tooltip-left lg:tooltip-right'`.
*
* Common values: `tooltip-left`, `tooltip-right`, `tooltip-top`, `tooltip-bottom`.
* Responsive variants are also valid, e.g. `'tooltip-left lg:tooltip-right'`.
*/
errorTooltipClass?: string;
};

export const AdvancedQueryFilter: FC<AdvancedQueryFilterProps> = ({ value, onInput, enabled, lapisUrl }) => {
export const AdvancedQueryFilter: FC<AdvancedQueryFilterProps> = ({
value,
onInput,
enabled,
lapisUrl,
errorTooltipClass,
}) => {
const [inputValue, setInputValue] = useState(value);
const [validationState, setValidationState] = useState<ValidationState>({ type: 'idle' });
const userEditedRef = useRef(false);
Expand Down Expand Up @@ -94,17 +108,20 @@ export const AdvancedQueryFilter: FC<AdvancedQueryFilterProps> = ({ value, onInp
/>
{isValidating && <span className='loading loading-spinner loading-xs' title='Validating' />}
{isValid && <div className='iconify mdi--check text-success size-4' title='Advanced query is valid' />}
{isError && <ErrorIconWithTooltip message={validationState.message} />}
{isError && <ErrorIconWithTooltip message={validationState.message} tooltipClass={errorTooltipClass} />}
Comment on lines 109 to +111
</label>
</div>
);
};

const ErrorIconWithTooltip: FC<{ message: string }> = ({ message }) => {
const ErrorIconWithTooltip: FC<{ message: string; tooltipClass?: string }> = ({
message,
tooltipClass = 'tooltip-left lg:tooltip-right',
}) => {
const [isOpen, setIsOpen] = useState(false);

return (
<div className={`tooltip tooltip-left lg:tooltip-right z-1000 ${isOpen ? 'tooltip-open' : ''}`}>
<div className={`tooltip ${tooltipClass} z-1000 ${isOpen ? 'tooltip-open' : ''}`}>
<div className='tooltip-content z-1000'>
<div className='flex items-start gap-1'>
<span>{message}</span>
Expand Down