refactor(website): rename wasap 'collection' mode to 'covSpectrumCollection' - #1325
Merged
Merged
Conversation
…ctrumCollection' Renames the mode string, filter component, type, and config key to make clear this mode is specific to CovSpectrum collections. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the W-ASAP (wastewater) website frontend to rename the existing CovSpectrum-backed analysis mode from 'collection' to 'covSpectrumCollection', clarifying that it is distinct from the upcoming GenSpectrum “collections” mode (Issue #1324) and keeping the URL-state model explicit.
Changes:
- Renamed the analysis mode discriminator string and config flag to
covSpectrumCollection*across page state handling, config types, and data fetching. - Renamed the corresponding filter component/type to
CovSpectrumCollection*to match the new mode name. - Updated wastewater defaults/config and adjusted unit/browser tests accordingly.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
website/src/views/pageStateHandlers/WasapPageStateHandler.ts |
Updates URL parse/serialize handling to use covSpectrumCollection mode. |
website/src/views/pageStateHandlers/WasapPageStateHandler.spec.ts |
Updates page-state handler tests for renamed mode/type/config defaults. |
website/src/types/wastewaterConfig.ts |
Updates organism config to enable and default to covSpectrumCollection mode where applicable. |
website/src/components/views/wasap/wasapPageConfig.ts |
Renames mode/type/config discriminants and enabled-modes list. |
website/src/components/views/wasap/useWasapPageData.ts |
Renames the collection-mode fetch path and its config flag checks. |
website/src/components/pageStateSelectors/wasap/WasapPageStateSelector.tsx |
Updates selector wiring (state, rendering, labels) for the renamed mode/component. |
website/src/components/pageStateSelectors/wasap/filters/CovSpectrumCollectionAnalysisFilter.tsx |
Renames the filter component/type usage to CovSpectrumCollection*. |
Comments suppressed due to low confidence (1)
website/src/components/pageStateSelectors/wasap/filters/CovSpectrumCollectionAnalysisFilter.tsx:12
website/AGENTS.mdrecommends using a named props type for React components (instead of an inline object type). Extracting the props improves readability and keeps this component consistent with the repo’s React conventions.
fengelniederhammer
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in anticipation of adding a 'collection' mode which will use the GenSpectrum collections: #1324
Summary
'collection'→'covSpectrumCollection'CollectionAnalysisFiltercomponent and files →CovSpectrumCollectionAnalysisFilterWasapCollectionFiltertype →WasapCovSpectrumCollectionFiltercollectionAnalysisModeEnabledconfig key →covSpectrumCollectionAnalysisModeEnabledfilterDefaults.collection→filterDefaults.covSpectrumCollectionthroughoutMakes it explicit that this mode is specific to CovSpectrum collections (as opposed to our own internal collections system).