Skip to content

Fix signup error#176

Merged
ZainabImadulla merged 3 commits intomainfrom
fix-signup-error
Nov 21, 2025
Merged

Fix signup error#176
ZainabImadulla merged 3 commits intomainfrom
fix-signup-error

Conversation

@ZainabImadulla
Copy link
Copy Markdown
Contributor

Description

[Link to Ticket](insert the link to your ticket inside the parenthesis here)

Please include a summary of the changes. If there were unexpected changes
to separate processes/components/dependencies, please explain why. Bullet list is fine!

Backend PRs:

  • I updated relevant API documentation and tests

Frontend PRs:

Page route(and description of how to get desired flow if necessary)

Please include any relevant images of the changes here.

Did any new/other issues pop up?

No

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

*/
export async function getAuthToken(): Promise<string> {
const supabase = createSupabaseClient();
("@ts-expect-error");
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't care about this error bc we validate the access token in the backend

user &&
user.user_metadata.onboarding_step &&
user.user_metadata.onboarding_step != requiredOnboardingProgress.FINISHED
(!isOnSignupPage &&
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can def simplify this boolean logic ... maybe tmr

@ZainabImadulla ZainabImadulla marked this pull request as ready for review November 20, 2025 05:15
Copy link
Copy Markdown
Contributor

@jacktoncelli jacktoncelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ZainabImadulla ZainabImadulla merged commit e2e38e7 into main Nov 21, 2025
3 checks passed
@ZainabImadulla ZainabImadulla deleted the fix-signup-error branch November 21, 2025 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants