Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 22 additions & 19 deletions backend/src/modules/purchase/service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,25 +61,28 @@ export class PurchaseService implements IPurchaseService {
async (payload: GetCompanyPurchasesDTO): Promise<GetCompanyPurchasesResponse> => {
const qbPurchases = await this.PurchaseTransaction.getPurchasesForCompany(payload);

return qbPurchases.map((qbPurchase) => ({
companyId: qbPurchase.companyId,
dateCreated: qbPurchase.dateCreated.toUTCString(),
id: qbPurchase.id,
isRefund: qbPurchase.isRefund,
quickBooksId: qbPurchase.quickBooksId,
vendor: qbPurchase.vendor ? qbPurchase.vendor : undefined,
totalAmountCents: Math.round(qbPurchase.totalAmountCents),
quickbooksDateCreated: qbPurchase.quickbooksDateCreated?.toUTCString(),
lastUpdated: qbPurchase.lastUpdated.toUTCString(),
lineItems: qbPurchase.lineItems
? qbPurchase.lineItems.map((item) => ({
...item,
dateCreated: item.dateCreated.toISOString(),
lastUpdated: item.lastUpdated.toISOString(),
quickbooksDateCreated: item.quickbooksDateCreated?.toISOString(),
}))
: [],
}));
return {
purchases: qbPurchases.purchases.map((qbPurchase) => ({
companyId: qbPurchase.companyId,
dateCreated: qbPurchase.dateCreated.toUTCString(),
id: qbPurchase.id,
isRefund: qbPurchase.isRefund,
quickBooksId: qbPurchase.quickBooksId,
vendor: qbPurchase.vendor ? qbPurchase.vendor : undefined,
totalAmountCents: Math.round(qbPurchase.totalAmountCents),
quickbooksDateCreated: qbPurchase.quickbooksDateCreated?.toUTCString(),
lastUpdated: qbPurchase.lastUpdated.toUTCString(),
lineItems: qbPurchase.lineItems
? qbPurchase.lineItems.map((item) => ({
...item,
dateCreated: item.dateCreated.toISOString(),
lastUpdated: item.lastUpdated.toISOString(),
quickbooksDateCreated: item.quickbooksDateCreated?.toISOString(),
}))
: [],
})),
numPurchases: qbPurchases.numPurchases,
};
}
);

Expand Down
12 changes: 8 additions & 4 deletions backend/src/modules/purchase/transaction.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,13 @@ import {
GetCompanyPurchasesByDateDTO,
GetCompanyPurchasesDTO,
GetCompanyPurchasesInMonthBinsResponse,
PurchasesWithCount,
} from "./types";

export interface IPurchaseTransaction {
createOrUpdatePurchase(payload: CreateOrChangePurchaseDTO): Promise<Purchase[]>;
getPurchase(id: string): Promise<Purchase>;
getPurchasesForCompany(payload: GetCompanyPurchasesDTO): Promise<Purchase[]>;
getPurchasesForCompany(payload: GetCompanyPurchasesDTO): Promise<PurchasesWithCount>;
sumPurchasesByCompanyAndDateRange(payload: GetCompanyPurchasesByDateDTO): Promise<number>;
sumPurchasesByCompanyInMonthBins(
payload: GetCompanyPurchasesByDateDTO
Expand Down Expand Up @@ -59,7 +60,7 @@ export class PurchaseTransaction implements IPurchaseTransaction {
return existingQBPurchase;
}

async getPurchasesForCompany(payload: GetCompanyPurchasesDTO): Promise<Purchase[]> {
async getPurchasesForCompany(payload: GetCompanyPurchasesDTO): Promise<PurchasesWithCount> {
const { companyId, pageNumber, resultsPerPage, categories, type, dateFrom, dateTo, search, sortBy, sortOrder } =
payload;

Expand Down Expand Up @@ -128,10 +129,12 @@ export class PurchaseTransaction implements IPurchaseTransaction {
queryBuilder.orderBy(sortColumnMap[sortBy], sortOrder);
}

const totalPurchases = await queryBuilder.getCount();

const idRows = await queryBuilder.skip(numToSkip).take(resultsPerPage).getMany();
const ids = idRows.map((row) => row.id);
if (ids.length === 0) {
return [];
return { purchases: [], numPurchases: 0 };
}

const queryBuilderForIds = this.db.manager
Expand All @@ -144,7 +147,8 @@ export class PurchaseTransaction implements IPurchaseTransaction {
}
// to guarantee that line items do not move in the table rows
queryBuilderForIds.addOrderBy("li.dateCreated", "ASC");
return await queryBuilderForIds.getMany();
const paginatedPurchases = await queryBuilderForIds.getMany();
return { purchases: paginatedPurchases, numPurchases: totalPurchases };
}

async sumPurchasesByCompanyAndDateRange(payload: GetCompanyPurchasesByDateDTO): Promise<number> {
Expand Down
14 changes: 13 additions & 1 deletion backend/src/modules/purchase/types.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { z } from "zod";
import { PurchaseLineItemType } from "../../entities/PurchaseLineItem";
import { GetPurchaseLineItemResponseSchema } from "../purchase-line-item/types";
import { Purchase } from "../../entities/Purchase";

export const CreateOrChangePurchaseRequestSchema = z.object({
items: z
Expand Down Expand Up @@ -95,7 +96,10 @@ export const GetCompanyPurchasesByDateDTOSchema = z.object({
endDate: z.iso.datetime(),
});

export const GetCompanyPurchasesResponseSchema = z.array(GetPurchaseWithLineItems);
export const GetCompanyPurchasesResponseSchema = z.object({
purchases: z.array(GetPurchaseWithLineItems),
numPurchases: z.number().nonnegative(),
});

export const GetCompanyPurchasesSummationResponseSchema = z.object({
total: z.number().nonnegative(),
Expand Down Expand Up @@ -124,3 +128,11 @@ export type CreateOrChangePurchaseDTO = z.infer<typeof CreateOrChangePurchaseDTO
export type GetCompanyPurchasesDTO = z.infer<typeof GetCompanyPurchasesDTOSchema>;
export type GetCompanyPurchasesByDateDTO = z.infer<typeof GetCompanyPurchasesByDateDTOSchema>;
export type GetPurchaseDTO = z.infer<typeof GetPurchaseDTOSchema>;

/**
* Types for the transaction layer
*/
export type PurchasesWithCount = {
purchases: Purchase[];
numPurchases: number;
};
Loading
Loading