Requests versioning 3 by oilagh · Pull Request #173 · GenerateNU/selfserve

oilagh · 2026-03-14T23:22:00Z

Description

modifies existing request enpoints to fetch the request with the latest version (in case of same ids)

Type of Change

Bug fix (non-breaking change that fixes an issue)
[ X ] New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Refactoring (code improvement without changing functionality)
Documentation update
Configuration/infrastructure change
Performance improvement
Test coverage improvement

Related Issue(s)

Closes #
Related to # #108

What Changed?

Essentially just update find request, find requests, and inert request at the repo level to change the way it accesses records from the DB
Add a new column request_version to DB

Testing & Validation

I only modified existing tests for our requests endpoints and made sure they passed.

How this was tested

Unit tests

Screenshots/Recordings

The below shows a POST request which makes a fresh request and 2 following PUT requests. As expected, the POST delivers a fresh id, created at, and request version. And the following PUT requests change the request version to date NOW() and maintains the created at and id of the request.

And finally I'll show you that GET request will serve up the latest version (timestamp) of the record stored

timestamp is 2026-03-17T21:47:13.232841-04:00 which aligns with the last PUT request we made

Unfinished Work & Known Issues

[ X] None, this PR is complete and production-ready

Notes & Nuances

Pre-Merge Checklist

Code Quality

Code follows the project's style guidelines and conventions
Self-review completed (I've reviewed my own code for obvious issues)
No debugging code, console logs, or commented-out code left behind
No merge conflicts with the base branch
Meaningful commit messages that explain the "why"

Testing & CI

All CI checks are passing
All new and existing tests pass locally
Test coverage hasn't decreased (or decrease is justified)
Linting passes without errors

Documentation

Code is self-documenting or includes helpful comments for complex logic
API documentation updated (if backend endpoints changed)
Type definitions are accurate and up-to-date

Reviewer Notes

Areas needing extra attention: ...
Questions for reviewers: ...

…, insert requests) and add migration to add column request_version to requests table and also make it so created_at which contains date created reflects the version because shud be the same

…ad as well as migration files

vercel · 2026-03-17T21:17:54Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
selfserve-web	Ready	Preview, Comment	Mar 18, 2026 1:04am

codecov · 2026-03-17T21:38:16Z

Codecov Report

❌ Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 12.65%. Comparing base (5b0b85e) to head (004bc09).

Files with missing lines	Patch %	Lines
backend/internal/repository/requests.go	0.00%	24 Missing ⚠️
backend/internal/handler/requests.go	0.00%	14 Missing ⚠️
backend/internal/service/server.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #173       +/-   ##
===========================================
- Coverage   23.00%   12.65%   -10.36%     
===========================================
  Files          34       79       +45     
  Lines        1143     2505     +1362     
  Branches        0       24       +24     
===========================================
+ Hits          263      317       +54     
- Misses        875     2183     +1308     
  Partials        5        5

Flag	Coverage Δ
backend	`22.51% <0.00%> (-0.50%)`	⬇️
mobile	`84.00% <ø> (?)`
web	`0.93% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
backend/internal/models/requests.go	`0.00% <ø> (ø)`
backend/internal/service/server.go	`0.00% <0.00%> (ø)`
backend/internal/handler/requests.go	`88.32% <0.00%> (-10.06%)`	⬇️
backend/internal/repository/requests.go	`0.00% <0.00%> (ø)`

... and 45 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…/adjust cursor request endpoint to reflect the new updated schema

* rooms migration file * feat: guest booking migration * rls fix * indexes on both tables * type fix * incomplete guest bookings table + endpoint * server integrated + openapi * moved getRooms to rooms repo * get guests endpoint * changes * fixed openapi * remove stale webhook dir * route for specific guest info * cleanup GetBookingsByFloor handler * changed some models * filtered by hotel id * lint * may the lint gods be merciful * comments * fixed issue * rename --------- Co-authored-by: eric-kitagawa <kitagawa.e@northeastern.edu>

…, insert requests) and add migration to add column request_version to requests table and also make it so created_at which contains date created reflects the version because shud be the same

Dao-Ho

some comments but overall logic looks great! 🔥 🚀

Dao-Ho · 2026-03-19T16:05:02Z

backend/internal/handler/requests.go

+		return errs.BadRequest("request id is not a valid UUID")
+	}
+
+	var incoming models.MakeRequest


Let's make this var more descriptive

Dao-Ho · 2026-03-19T16:05:25Z

backend/internal/handler/requests.go

+	if err := c.BodyParser(&incoming); err != nil {
+		return errs.InvalidJSON()
+	}
+	req := models.Request{ID: id, MakeRequest: incoming}


same with this var, more descriptive please 🙏

Dao-Ho · 2026-03-19T16:06:28Z

backend/internal/handler/requests.go

+
+	if err := validateCreateRequest(&req); err != nil {
+		return err
+	}


we also have a validation system in place, let's remove this validateCreateRequest and use the validation Zaydaan added.

Please look at how BindAndValidate is used in our users.go file in the handler

if err := httpx.BindAndValidate(c, &CreateUserRequest); err != nil { return err }

Dao-Ho · 2026-03-19T16:12:21Z

backend/internal/repository/requests.go

-	`, req.HotelID, req.GuestID, req.UserID, req.ReservationID, req.Name,
+	if req.ID == "" {
+		req.ID = uuid.New().String()
+	}


shouldn't be the CRUD's job to create a new ID, let's throw an error if this is the case. Should be on the caller for passing this id value

Dao-Ho · 2026-03-19T16:16:54Z

backend/internal/repository/requests.go

 		req.Status, req.Priority, req.EstimatedCompletionTime,
-		req.ScheduledTime, req.Notes).Scan(&req.ID, &req.CreatedAt, &req.UpdatedAt)
+		req.ScheduledTime, req.Notes).Scan(&req.ID, &req.CreatedAt, &req.RequestVersion)



niceee 🔥

Dao-Ho · 2026-03-19T16:18:13Z

backend/supabase/migrations/20260217134812_add-request-version-column.sql

 ALTER COLUMN request_version DROP DEFAULT;

-ALTER TABLE public.requests DROP COLUMN updated_at
+ALTER TABLE public.requests DROP COLUMN updated_at


let's move this to a new migration file - each new migration should be its own separate file.

Also, this should be it's own separate PR. Every migration should be a separate pr

Dao-Ho · 2026-03-19T16:18:24Z

backend/supabase/migrations/20260317000000_requests-composite-pk.sql

 ALTER TABLE public.requests DROP CONSTRAINT requests_pkey;

-ALTER TABLE public.requests ADD CONSTRAINT requests_pkey PRIMARY KEY (id, request_version);
+ALTER TABLE public.requests ADD CONSTRAINT requests_pkey PRIMARY KEY (id, request_version);


same with this - separate PR and file

Dao-Ho · 2026-03-19T16:18:54Z

backend/dump.sql

+
+
+
+


what is this file? I don't think you meant to commit this

oilagh added 5 commits February 17, 2026 16:35

Update repository methods for versioning (find request, find requests…

97e712e

…, insert requests) and add migration to add column request_version to requests table and also make it so created_at which contains date created reflects the version because shud be the same

fixed SQL statement

62d0eb0

remove supabase migration

4711ee7

make changes to the request schema and format repo

78d60eb

fully tested the versioning and added PUT endpoint into this PR inste…

e207b14

…ad as well as migration files

vercel bot deployed to Preview March 17, 2026 21:18 View deployment

Merge branch 'main' into requests-versioning-2

cd0a398

vercel bot deployed to Preview March 17, 2026 21:22 View deployment

oilagh changed the title ~~Requests versioning 2~~ Requests versioning Mar 17, 2026

fix formatting and write update tests and fix merge conflict remnants…

a6a098f

…/adjust cursor request endpoint to reflect the new updated schema

vercel bot deployed to Preview March 17, 2026 21:46 View deployment

change types in frontend to match as well

c475baa

vercel bot deployed to Preview March 17, 2026 21:49 View deployment

manueltorres0 and others added 3 commits March 17, 2026 21:02

Update repository methods for versioning (find request, find requests…

7836bee

…, insert requests) and add migration to add column request_version to requests table and also make it so created_at which contains date created reflects the version because shud be the same

fixed SQL statement

ea363d9

vercel bot deployed to Preview March 18, 2026 01:04 View deployment

oilagh changed the title ~~Requests versioning~~ Requests versioning 3 Mar 18, 2026

remove duplicate migration file

09e08ae

vercel bot deployed to Preview March 18, 2026 01:40 View deployment

Merge branch 'main' into requests-versioning-2

004bc09

vercel bot deployed to Preview March 18, 2026 01:42 View deployment

Dao-Ho requested changes Mar 19, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Requests versioning 3#173

Requests versioning 3#173
oilagh wants to merge 13 commits intomainfrom
requests-versioning-2

oilagh commented Mar 14, 2026 •

edited

Loading

Uh oh!

vercel bot commented Mar 17, 2026 •

edited

Loading

Uh oh!

codecov bot commented Mar 17, 2026 •

edited

Loading

Uh oh!

Dao-Ho left a comment

Uh oh!

Dao-Ho Mar 19, 2026

Uh oh!

Dao-Ho Mar 19, 2026

Uh oh!

Dao-Ho Mar 19, 2026

Uh oh!

Dao-Ho Mar 19, 2026

Uh oh!

Dao-Ho Mar 19, 2026

Uh oh!

Dao-Ho Mar 19, 2026

Uh oh!

Dao-Ho Mar 19, 2026

Uh oh!

Dao-Ho Mar 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

oilagh commented Mar 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of Change

Related Issue(s)

What Changed?

Testing & Validation

How this was tested

Screenshots/Recordings

Unfinished Work & Known Issues

Notes & Nuances

Pre-Merge Checklist

Code Quality

Testing & CI

Documentation

Reviewer Notes

Uh oh!

vercel bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Dao-Ho left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

oilagh commented Mar 14, 2026 •

edited

Loading

vercel bot commented Mar 17, 2026 •

edited

Loading

codecov bot commented Mar 17, 2026 •

edited

Loading