Skip to content

feat: auth lo fi screens#184

Open
tars919 wants to merge 10 commits intomainfrom
onboarding-lofi
Open

feat: auth lo fi screens#184
tars919 wants to merge 10 commits intomainfrom
onboarding-lofi

Conversation

@tars919
Copy link
Contributor

@tars919 tars919 commented Mar 17, 2026

Description

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (code improvement without changing functionality)
  • Documentation update
  • Configuration/infrastructure change
  • Performance improvement
  • Test coverage improvement

Related Issue(s)

Closes #
Related to #

What Changed?

  • full onboarding flow with 5 steps
  • Shared LeftPanel component reused across all steps to keep layout consistent
  • All steps use mock/local data for now, no backend integration yet

Testing & Validation

How this was tested

  1. Ran the web dev server locally
  2. Clicked through the Employee flow and manager flow

Screenshots/Recordings

Unfinished Work & Known Issues

  • [x ] None, this PR is complete and production-ready
  • The following items are intentionally deferred:



Notes & Nuances



Pre-Merge Checklist

Code Quality

  • [x ] Code follows the project's style guidelines and conventions
  • [ x] Self-review completed (I've reviewed my own code for obvious issues)
  • [x ] No debugging code, console logs, or commented-out code left behind
  • [x ] No merge conflicts with the base branch
  • [x ] Meaningful commit messages that explain the "why"

Testing & CI

  • [x ] All CI checks are passing
  • [x ] All new and existing tests pass locally
  • [x ] Test coverage hasn't decreased (or decrease is justified)
  • [ x] Linting passes without errors

Documentation

  • [x ] Code is self-documenting or includes helpful comments for complex logic
  • [x ] API documentation updated (if backend endpoints changed)
  • [x ] Type definitions are accurate and up-to-date

Reviewer Notes

  • Areas needing extra attention: ...
  • Questions for reviewers: ...

@codecov
Copy link

codecov bot commented Mar 17, 2026

Codecov Report

❌ Patch coverage is 0.15823% with 631 lines in your changes missing coverage. Please review.
✅ Project coverage is 10.21%. Comparing base (61c284c) to head (93a60bc).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...s/web/src/components/onboarding/InviteTeamStep.tsx 0.00% 116 Missing ⚠️
.../src/components/onboarding/PropertyDetailsStep.tsx 0.00% 116 Missing ⚠️
...eb/src/components/onboarding/RoleSelectionStep.tsx 0.00% 88 Missing ⚠️
...web/src/components/onboarding/EmployeeRoleStep.tsx 0.00% 83 Missing ⚠️
...ents/web/src/components/onboarding/WelcomeStep.tsx 0.00% 72 Missing ⚠️
...s/web/src/components/onboarding/OnboardingPage.tsx 0.00% 67 Missing ⚠️
...lients/web/src/components/onboarding/LeftPanel.tsx 0.00% 31 Missing ⚠️
...s/web/src/components/onboarding/onboardingMocks.ts 0.00% 29 Missing ⚠️
clients/web/src/components/onboarding/RoleCard.tsx 5.26% 18 Missing ⚠️
clients/web/src/routeTree.gen.ts 0.00% 7 Missing ⚠️
... and 1 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##            main     #184      +/-   ##
=========================================
+ Coverage   4.03%   10.21%   +6.17%     
=========================================
  Files         45       89      +44     
  Lines       1337     3112    +1775     
  Branches      24       24              
=========================================
+ Hits          54      318     +264     
- Misses      1283     2789    +1506     
- Partials       0        5       +5     
Flag Coverage Δ
backend 23.00% <ø> (?)
mobile 84.00% <ø> (ø)
web 0.67% <0.15%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
clients/web/src/routes/onboarding.tsx 0.00% <0.00%> (ø)
clients/web/src/routeTree.gen.ts 0.00% <0.00%> (ø)
clients/web/src/components/onboarding/RoleCard.tsx 5.26% <5.26%> (ø)
...s/web/src/components/onboarding/onboardingMocks.ts 0.00% <0.00%> (ø)
...lients/web/src/components/onboarding/LeftPanel.tsx 0.00% <0.00%> (ø)
...s/web/src/components/onboarding/OnboardingPage.tsx 0.00% <0.00%> (ø)
...ents/web/src/components/onboarding/WelcomeStep.tsx 0.00% <0.00%> (ø)
...web/src/components/onboarding/EmployeeRoleStep.tsx 0.00% <0.00%> (ø)
...eb/src/components/onboarding/RoleSelectionStep.tsx 0.00% <0.00%> (ø)
...s/web/src/components/onboarding/InviteTeamStep.tsx 0.00% <0.00%> (ø)
... and 1 more

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vercel
Copy link

vercel bot commented Mar 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
selfserve-web Ready Ready Preview, Comment Mar 18, 2026 0:36am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants