Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
===========================================
+ Coverage 24.73% 84.00% +59.26%
===========================================
Files 37 7 -30
Lines 1237 50 -1187
Branches 0 24 +24
===========================================
- Hits 306 42 -264
+ Misses 926 8 -918
+ Partials 5 0 -5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Dao-Ho
requested changes
Mar 25, 2026
| const [email, setEmail] = useState<string>(""); | ||
| const [password, setPassword] = useState<string>(""); | ||
| const [error, setError] = useState(""); | ||
| const run = useClerkErrorHandler(setError); |
Contributor
There was a problem hiding this comment.
can we make this var more descriptive?
| run(async () => { | ||
| if (!isLoaded || !signIn || !setActive) return; | ||
| const result = await signIn.create({ identifier: email, password }); | ||
| if (result.status === "complete") { |
Contributor
There was a problem hiding this comment.
can we make complete an enum?
|
|
||
| {error ? ( | ||
| <Text className="text-danger text-sm mb-4">{error}</Text> | ||
| ) : null} |
Contributor
There was a problem hiding this comment.
Suggested change
| ) : null} | |
| {error && ( | |
| <Text className="text-danger text-sm mb-4">{error}</Text> | |
| )} |
| try { | ||
| await action(); | ||
| } catch (err: any) { | ||
| setError(err.errors?.[0]?.message); |
Contributor
There was a problem hiding this comment.
This looks good but just wanna double check that this is standard error format for all errors returned by clerk
Contributor
Author
There was a problem hiding this comment.
yes, just double checked
|
|
||
| {error ? ( | ||
| <Text className="text-danger text-sm mb-4">{error}</Text> | ||
| ) : null} |
clients/mobile/app/(auth)/verify.tsx
Outdated
|
|
||
| {error ? ( | ||
| <Text className="text-danger text-sm mb-4">{error}</Text> | ||
| ) : null} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DEMO
Type of Change
Testing & Validation
How this was tested
Unfinished Work & Known Issues
Pre-Merge Checklist
Code Quality
Testing & CI
Documentation