Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
==========================================
- Coverage 11.49% 11.14% -0.36%
==========================================
Files 99 102 +3
Lines 3166 3257 +91
Branches 24 24
==========================================
- Hits 364 363 -1
- Misses 2798 2890 +92
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
eric-kitagawa
changed the title
| }; | ||
|
|
||
| function sortRoomsByRoomNumber( | ||
| rooms: Array<RoomWithOptionalGuestBooking>, |
There was a problem hiding this comment.
ILoRoomWithOptionalGuestBooking
There was a problem hiding this comment.
Is this a fundies reference? 😭
| children, | ||
| }: PageShellProps) { | ||
| const hasDrawer = !!drawer; | ||
| const hasDrawer = drawer !== undefined; |
There was a problem hiding this comment.
is this fine type wise?
There was a problem hiding this comment.
this valid actually better than the coercion now that I look at it
danctila
left a comment
danctila
left a comment
There was a problem hiding this comment.
this looks good to me but just want to make sure all the new components are directly related / needed for the change to just add the sort by button. if not it would be better to split this into one PR only for the bare minimum to have your sort by button there and then another for nice to have components that aren't related to that - i could be wrong though and it's all used
Dao-Ho
left a comment
Dao-Ho
left a comment
There was a problem hiding this comment.
LGTM!!! Let's goo, it's looking so good 🔥 Just some comments for future reference, especially the sorting functionality. This PR is good to be merged though
| )} | ||
| </div> | ||
| ); | ||
| } |
There was a problem hiding this comment.
This is good but def shadcn for future cases, you're the goat for cooking up from scratch though
| }; | ||
|
|
||
| function sortRoomsByRoomNumber( | ||
| rooms: Array<RoomWithOptionalGuestBooking>, |
There was a problem hiding this comment.
Is this a fundies reference? 😭
| const bn = b.room_number ?? 0; | ||
| return ascending ? an - bn : bn - an; | ||
| }); | ||
| } |
There was a problem hiding this comment.
we wanna do this sorting on the backend at the query level, we can merge this in for now but let's add that as a field to our request body as an optional sorting in a different pr
3 participants
needs #206 to merge first
Added the sortby button to the rooms page
you can now filter by room number in ascending or descending.
orderby-dropdown-3-24.mov