Skip to content

refactor: change get to post for rooms filter#212

Closed
eric-kitagawa wants to merge 1 commit intomainfrom
eric/post-rooms-filter-endpoint
Closed

refactor: change get to post for rooms filter#212
eric-kitagawa wants to merge 1 commit intomainfrom
eric/post-rooms-filter-endpoint

Conversation

@eric-kitagawa
Copy link
Contributor

change the filter rooms endpoint from a get to a post

tbd:

  • needs to support more than just floors but can be done in later prs

@eric-kitagawa eric-kitagawa self-assigned this Mar 25, 2026
@eric-kitagawa eric-kitagawa marked this pull request as ready for review March 25, 2026 00:55
@codecov
Copy link

codecov bot commented Mar 25, 2026

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 11.23%. Comparing base (eaa77fe) to head (a433ede).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
backend/internal/service/server.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #212       +/-   ##
===========================================
- Coverage   24.73%   11.23%   -13.51%     
===========================================
  Files          37       95       +58     
  Lines        1237     3258     +2021     
  Branches        0       24       +24     
===========================================
+ Hits          306      366       +60     
- Misses        926     2888     +1962     
+ Partials        5        4        -1     
Flag Coverage Δ
backend 25.02% <90.00%> (+0.28%) ⬆️
mobile 84.00% <ø> (?)
web 0.71% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
backend/internal/handler/rooms.go 93.75% <100.00%> (+7.08%) ⬆️
backend/internal/service/server.go 0.00% <0.00%> (ø)

... and 58 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant