Skip to content

fix/tabBar + landing routing#213

Merged
manueltorres0 merged 6 commits intomainfrom
fix/tab
Mar 25, 2026
Merged

fix/tabBar + landing routing#213
manueltorres0 merged 6 commits intomainfrom
fix/tab

Conversation

@manueltorres0
Copy link
Contributor

  • fixed the mobile tab bar to match figma

@codecov
Copy link

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.00%. Comparing base (bacf1fe) to head (af4bf8c).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #213   +/-   ##
=======================================
  Coverage   84.00%   84.00%           
=======================================
  Files           7        7           
  Lines          50       50           
  Branches       24       24           
=======================================
  Hits           42       42           
  Misses          8        8           
Flag Coverage Δ
mobile 84.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
clients/mobile/constants/theme.ts 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@manueltorres0 manueltorres0 changed the title styling done with color vars fix/tabBar + landing routing Mar 25, 2026
Copy link
Contributor

@Dao-Ho Dao-Ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments given irl as well

minWidth: 64,
}}
className="rounded-xl px-3 py-1 items-center gap-1"
>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be able to use native wind here

numberOfLines={1}
style={{ color: activeColor }}
className="text-xs font-medium"
>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

native wind

Copy link
Contributor

@Dao-Ho Dao-Ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅ ✅ ✅

@manueltorres0 manueltorres0 merged commit 3cf1d36 into main Mar 25, 2026
7 checks passed
@manueltorres0 manueltorres0 deleted the fix/tab branch March 25, 2026 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants