Skip to content

feat: add guests search backend + group_size filter #218

Merged
zaydaanjahangir merged 6 commits intomainfrom
feat/add-guests-search-backend
Mar 26, 2026
Merged

feat: add guests search backend + group_size filter #218
zaydaanjahangir merged 6 commits intomainfrom
feat/add-guests-search-backend

Conversation

@zaydaanjahangir
Copy link
Contributor

@zaydaanjahangir zaydaanjahangir commented Mar 25, 2026

Description

We want to add search functionality and filtering by group size on the guests

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (code improvement without changing functionality)
  • Documentation update
  • Configuration/infrastructure change
  • Performance improvement
  • Test coverage improvement

Related Issue(s)

Related to #129

What Changed?

  • Now we can add search and group_size as filters

Testing & Validation

How this was tested

  1. Unit tests
  2. Tested locally w/Postman

Notes & Nuances



Pre-Merge Checklist

Code Quality

  • Code follows the project's style guidelines and conventions
  • Self-review completed (I've reviewed my own code for obvious issues)
  • No debugging code, console logs, or commented-out code left behind
  • No merge conflicts with the base branch
  • Meaningful commit messages that explain the "why"

Testing & CI

  • All CI checks are passing
  • All new and existing tests pass locally
  • Test coverage hasn't decreased (or decrease is justified)
  • Linting passes without errors

Documentation

  • Code is self-documenting or includes helpful comments for complex logic
  • API documentation updated (if backend endpoints changed)
  • Type definitions are accurate and up-to-date

Reviewer Notes

  • Areas needing extra attention: ...
  • Questions for reviewers: ...

@codecov
Copy link

codecov bot commented Mar 25, 2026

Codecov Report

❌ Patch coverage is 23.63636% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 11.23%. Comparing base (1740e94) to head (e31a5f4).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
backend/internal/repository/guests.go 0.00% 42 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #218       +/-   ##
===========================================
- Coverage   24.23%   11.23%   -13.00%     
===========================================
  Files          37      103       +66     
  Lines        1267     3347     +2080     
  Branches        0       24       +24     
===========================================
+ Hits          307      376       +69     
- Misses        956     2967     +2011     
  Partials        4        4               
Flag Coverage Δ
backend 24.52% <23.63%> (+0.29%) ⬆️
mobile 84.00% <ø> (?)
web 0.70% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
backend/internal/handler/guests.go 100.00% <100.00%> (ø)
backend/internal/repository/guests.go 0.00% <0.00%> (ø)

... and 66 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zaydaanjahangir zaydaanjahangir changed the title feat: add guests search backend + group_size filter feat: add guests search backend + group_size filter [STILL TESTING] Mar 25, 2026
@zaydaanjahangir zaydaanjahangir changed the title feat: add guests search backend + group_size filter [STILL TESTING] feat: add guests search backend + group_size filter [TESTING LOCALLY] Mar 25, 2026
@zaydaanjahangir zaydaanjahangir marked this pull request as ready for review March 25, 2026 08:56
@zaydaanjahangir zaydaanjahangir changed the title feat: add guests search backend + group_size filter [TESTING LOCALLY] feat: add guests search backend + group_size filter Mar 25, 2026
Copy link
Contributor

@Dao-Ho Dao-Ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is HUGE, some comments but overall query looks solid to me!

@zaydaanjahangir zaydaanjahangir requested a review from Dao-Ho March 26, 2026 00:12
Copy link
Contributor

@Dao-Ho Dao-Ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@zaydaanjahangir
Copy link
Contributor Author

LGTM ✅

mashallah

@zaydaanjahangir zaydaanjahangir merged commit 4701446 into main Mar 26, 2026
16 checks passed
@zaydaanjahangir zaydaanjahangir deleted the feat/add-guests-search-backend branch March 26, 2026 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants