Skip to content

feat: urgent icon#256

Merged
Dao-Ho merged 2 commits intomainfrom
dao/icon-warning
Apr 4, 2026
Merged

feat: urgent icon#256
Dao-Ho merged 2 commits intomainfrom
dao/icon-warning

Conversation

@Dao-Ho
Copy link
Copy Markdown
Contributor

@Dao-Ho Dao-Ho commented Apr 4, 2026

template for how to import custom icons via svg

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 4, 2026

Codecov Report

❌ Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.76%. Comparing base (5ae7bfe) to head (98728b2).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
clients/web/src/icons/urgent.tsx 0.00% 17 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (5ae7bfe) and HEAD (98728b2). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5ae7bfe) HEAD (98728b2)
backend 1 0
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #256       +/-   ##
==========================================
- Coverage   22.69%   0.76%   -21.93%     
==========================================
  Files          37      68       +31     
  Lines        1300    2346     +1046     
==========================================
- Hits          295      18      -277     
- Misses       1002    2328     +1326     
+ Partials        3       0        -3     
Flag Coverage Δ
backend ?
web 0.76% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
clients/web/src/icons/urgent.tsx 0.00% <0.00%> (ø)

... and 104 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -0,0 +1,5 @@
export function UrgentIcon(props: React.SVGProps<SVGSVGElement>) {
return <svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg" {...props}>
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that props are appended so you can style as needed

@@ -0,0 +1,5 @@
export function UrgentIcon(props: React.SVGProps<SVGSVGElement>) {
return <svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg" {...props}>
<path d="M8 5V8M8 11H8.0075M15.5 8C15.5 12.1421 12.1421 15.5 8 15.5C3.85786 15.5 0.5 12.1421 0.5 8C0.5 3.85786 3.85786 0.5 8 0.5C12.1421 0.5 15.5 3.85786 15.5 8Z" stroke="currentColor" strokeLinecap="round" strokeLinejoin="round" />
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that all hex colors are removed to be currentColor so that there aren't any hardcoded colors.

Also all props here are camel case

@Dao-Ho Dao-Ho marked this pull request as ready for review April 4, 2026 14:37
@eric-kitagawa eric-kitagawa self-requested a review April 4, 2026 14:38
@Dao-Ho Dao-Ho merged commit b96db23 into main Apr 4, 2026
8 checks passed
@Dao-Ho Dao-Ho deleted the dao/icon-warning branch April 4, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants