Skip to content

feat: add room task component#264

Merged
eric-kitagawa merged 9 commits intomainfrom
eric/rooms-task-card
Apr 4, 2026
Merged

feat: add room task component#264
eric-kitagawa merged 9 commits intomainfrom
eric/rooms-task-card

Conversation

@eric-kitagawa
Copy link
Copy Markdown
Contributor

@eric-kitagawa eric-kitagawa commented Apr 4, 2026

add task hifi component for rooms page

  • optional assign to self field
  • task lists component to map alla them out
  • hardcoded data for now will hook up in next pr

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 4, 2026

Codecov Report

❌ Patch coverage is 0.67568% with 147 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.75%. Comparing base (9095ced) to head (ea12007).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...ients/web/src/components/rooms/RoomRequestCard.tsx 0.00% 89 Missing ⚠️
clients/web/src/components/rooms/RoomsOverview.tsx 0.00% 29 Missing ⚠️
...ients/web/src/components/rooms/RoomRequestList.tsx 3.44% 28 Missing ⚠️
clients/web/src/components/rooms/OverviewCard.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##            main    #264    +/-   ##
======================================
  Coverage   0.75%   0.75%            
======================================
  Files         67      68     +1     
  Lines       2379    2508   +129     
======================================
+ Hits          18      19     +1     
- Misses      2361    2489   +128     
Flag Coverage Δ
web 0.75% <0.67%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
clients/web/src/components/rooms/OverviewCard.tsx 1.92% <0.00%> (ø)
...ients/web/src/components/rooms/RoomRequestList.tsx 3.44% <3.44%> (ø)
clients/web/src/components/rooms/RoomsOverview.tsx 1.13% <0.00%> (-0.51%) ⬇️
...ients/web/src/components/rooms/RoomRequestCard.tsx 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eric-kitagawa eric-kitagawa marked this pull request as ready for review April 4, 2026 18:16
@eric-kitagawa eric-kitagawa requested a review from Dao-Ho April 4, 2026 18:16
@eric-kitagawa eric-kitagawa self-assigned this Apr 4, 2026
@eric-kitagawa eric-kitagawa added feature Introduces a new and complete feature feat(urethon) needs review labels Apr 4, 2026
Copy link
Copy Markdown
Contributor

@Dao-Ho Dao-Ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fire 🔥 just two nits on converting any hard coded pixels to rem

Dao-Ho
Dao-Ho previously approved these changes Apr 4, 2026
Copy link
Copy Markdown
Contributor

@Dao-Ho Dao-Ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Copy link
Copy Markdown
Contributor

@Dao-Ho Dao-Ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@eric-kitagawa eric-kitagawa merged commit b5f4402 into main Apr 4, 2026
7 checks passed
@eric-kitagawa eric-kitagawa deleted the eric/rooms-task-card branch April 4, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat(urethon) feature Introduces a new and complete feature needs review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants