Skip to content

Backend Notifications: 1 - migrations#265

Merged
danctila merged 2 commits intomainfrom
danc/notifications-migrations
Apr 4, 2026
Merged

Backend Notifications: 1 - migrations#265
danctila merged 2 commits intomainfrom
danc/notifications-migrations

Conversation

@danctila
Copy link
Copy Markdown
Contributor

@danctila danctila commented Apr 4, 2026

Description

Adds the two Postgres migrations needed to support the upcoming notification system.

Type of Change

  • New feature (non-breaking change that adds functionality)

Related Issue(s)

Working towards #97

What Changed?

  • Added public.notifications table to store in-app notifications per user, with a (user_id, created_at desc) index
  • Added public.device_tokens table to store Expo push tokens for mobile, with a unique(user_id, token) constraint

Unfinished Work & Known Issues

  • The following items are intentionally deferred:
    • Application code (repository, service, handler, routes)
    • Web notifications
    • Mobile expo-notifications registration

Pre-Merge Checklist

Code Quality

  • Code follows the project's style guidelines and conventions
  • Self-review completed (I've reviewed my own code for obvious issues)
  • No debugging code, console logs, or commented-out code left behind
  • No merge conflicts with the base branch
  • Meaningful commit messages that explain the "why"

Testing & CI

  • All CI checks are passing
  • Linting passes without errors

Documentation

  • Code is self-documenting or includes helpful comments for complex logic

@danctila danctila self-assigned this Apr 4, 2026
@danctila danctila added feature Introduces a new and complete feature feat(urethon) labels Apr 4, 2026
@danctila danctila marked this pull request as ready for review April 4, 2026 18:37
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.24%. Comparing base (e89757c) to head (352a93e).
⚠️ Report is 2 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (e89757c) and HEAD (352a93e). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (e89757c) HEAD (352a93e)
mobile 1 0
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #265       +/-   ##
===========================================
- Coverage   84.00%   18.24%   -65.76%     
===========================================
  Files           7       42       +35     
  Lines          50     1716     +1666     
  Branches       24        0       -24     
===========================================
+ Hits           42      313      +271     
- Misses          8     1397     +1389     
- Partials        0        6        +6     
Flag Coverage Δ
backend 18.24% <ø> (?)
mobile ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 49 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eric-kitagawa
Copy link
Copy Markdown
Contributor

i love you

Copy link
Copy Markdown
Contributor

@Dao-Ho Dao-Ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐐

@danctila danctila merged commit 996bf5f into main Apr 4, 2026
6 checks passed
@danctila danctila deleted the danc/notifications-migrations branch April 4, 2026 18:52
@danctila danctila mentioned this pull request Apr 4, 2026
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat(urethon) feature Introduces a new and complete feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants