Skip to content

feat: Update swagger to remove /api/v1 prefix on hotels and guests#333

Merged
zaydaanjahangir merged 1 commit intomainfrom
fix/fix-inconsistent-swagger
Apr 13, 2026
Merged

feat: Update swagger to remove /api/v1 prefix on hotels and guests#333
zaydaanjahangir merged 1 commit intomainfrom
fix/fix-inconsistent-swagger

Conversation

@zaydaanjahangir
Copy link
Copy Markdown
Contributor

@zaydaanjahangir zaydaanjahangir commented Apr 13, 2026

Description

Swagger for hotels and guests is inconsistent with some including the /api/v1 prefix on the swaggerdoc. We assume the base url includes /api/v1 so these prefixes cause inconsistencies within the swagger and lead to requests that duplicate this prefix. Removing this and updating the associated names fixes this.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 6.38%. Comparing base (dd1a547) to head (aeabeec).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##            main    #333      +/-   ##
========================================
+ Coverage   0.49%   6.38%   +5.89%     
========================================
  Files         91     139      +48     
  Lines       4456    7111    +2655     
========================================
+ Hits          22     454     +432     
- Misses      4434    6641    +2207     
- Partials       0      16      +16     
Flag Coverage Δ
backend 16.27% <ø> (?)
web 0.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
backend/internal/handler/guests.go 97.56% <ø> (ø)
backend/internal/handler/hotels.go 22.47% <ø> (ø)

... and 46 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zaydaanjahangir zaydaanjahangir changed the title feat: Update swagger to remove /api/v1 feat: Update swagger to remove /api/v1 prefix on hotels and guests Apr 13, 2026
@zaydaanjahangir zaydaanjahangir merged commit 3e726b3 into main Apr 13, 2026
17 checks passed
@zaydaanjahangir zaydaanjahangir deleted the fix/fix-inconsistent-swagger branch April 13, 2026 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants