feat: redesign guest list table and extract filter popover#334
Merged
zaydaanjahangir merged 7 commits intomainfrom Apr 15, 2026
Merged
feat: redesign guest list table and extract filter popover#334zaydaanjahangir merged 7 commits intomainfrom
zaydaanjahangir merged 7 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #334 +/- ##
========================================
- Coverage 9.14% 8.58% -0.56%
========================================
Files 144 146 +2
Lines 7581 7748 +167
Branches 22 27 +5
========================================
- Hits 693 665 -28
- Misses 6872 7066 +194
- Partials 16 17 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
zaydaanjahangir
commented
Apr 15, 2026
Contributor
Author
zaydaanjahangir
left a comment
zaydaanjahangir
left a comment
There was a problem hiding this comment.
@claude can you review this PR
Dao-Ho
previously approved these changes
Apr 15, 2026
Contributor
Dao-Ho
left a comment
Dao-Ho
left a comment
There was a problem hiding this comment.
One cmt but is good to merge if not possible
| document.removeEventListener("mousedown", handleMouseDown); | ||
| document.removeEventListener("keydown", handleKeyDown); | ||
| }; | ||
| }, [open]); |
Contributor
There was a problem hiding this comment.
Feels like there's a most modern approach to doing key listens aside from a document get. If not, this is good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR 1/3 for guests hifis, the duplicate guests showing for having multiple bookings is a backend problem to handle