Skip to content

Conversation

@michaelgrund
Copy link
Member

Description of proposed changes

In the definition it's length, so replace width by length in the description.

Reminders

  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

In the definition it's *length*, so replace *width* by *length* in the description.
Copy link
Member

@joa-quim joa-quim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the description is wrong. It really means the height and states that the default height is equal to bar's width.

@michaelgrund
Copy link
Member Author

I don't think the description is wrong. It really means the height and states that the default height is equal to bar's width.

For me that's unclear. In the paramter list it's length (why not width then):
image

and in the description:
image

@joa-quim
Copy link
Member

Yep, the length in the option synopsis may be a bit misleading, but just a little since it's neither width nor height so it should not be confusing either.

@michaelgrund
Copy link
Member Author

ok, if you might this is clear then we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants