Figure.histogram: Split parameter bar_width into bar_width and bar_offset #4316
+25
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
reviewed
Dec 21, 2025
| bar_width=f"{binwidth / 2}+o-{binwidth / 4}", | ||
| bar_width=binwidth / 2, | ||
| # Offset the bars to align each bar with the left limit of the corresponding bin | ||
| bar_offset=binwidth / 4, |
Member
There was a problem hiding this comment.
negative offset.
Suggested change
| bar_offset=binwidth / 4, | |
| bar_offset=-binwidth / 4, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR splits the parameter
bar_widthinto two parametersbar_widthandbar_offsetto make the codes more Pythonic.Related to #4279 (comment). Extends #4279
Preview:
Guidelines
Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash command is:
/format: automatically format and lint the code