[FEATURE] Allow mounted cameras to be run in parallel simulations#1323
Merged
duburcqa merged 3 commits intoGenesis-Embodied-AI:mainfrom Jul 3, 2025
Merged
Conversation
37aae22 to
ed46743
Compare
Merged
YilingQiao
reviewed
Jun 26, 2025
Collaborator
|
Must add a unit test, either as part of |
ed46743 to
6e171d4
Compare
Contributor
Author
@duburcqa Added a separate test. Let me know if that needs changes |
duburcqa
reviewed
Jul 1, 2025
a13e7d0 to
9a5b13e
Compare
Contributor
Author
|
Thanks for the review, addressed comments |
duburcqa
approved these changes
Jul 2, 2025
Collaborator
|
Good job! Ready to merge 👍 |
Milotrince
pushed a commit
to Milotrince/Genesis
that referenced
this pull request
Jul 5, 2025
This was referenced Jul 10, 2025
chris-la-humalab
pushed a commit
to HumaLab/Genesis
that referenced
this pull request
Aug 1, 2025
YilingQiao
pushed a commit
to YilingQiao/Genesis
that referenced
this pull request
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When running in parallel environments, while attaching the camera to the link, you need to specify the environment index (
env_idx) for each camera. This offsets the local Transform (T) to the corresponding environment offsetRelated Issue
Resolves #1016
Motivation and Context
Previous PR introduced mounting cameras to the rigid body links (example: robot end-effector). However it did not support running such mounted cameras in parallel environments.
How Has This Been / Can This Be Tested?
To run in parallel environments, use this (change the
n_envsto the number of parallel simulations to run)To verify this is still functional on non parallel environments, run this
Video Demo:
genesis-parallel-camera-mounts.webm
Checklist:
Submitting Code Changessection of CONTRIBUTING document.