Skip to content

[FEATURE] Flush benchmarking results after each test#1333

Merged
Genesis-Embodied-AI merged 1 commit intoGenesis-Embodied-AI:mainfrom
hughperkins:hp/flush-benchmarking-results
Jun 29, 2025
Merged

[FEATURE] Flush benchmarking results after each test#1333
Genesis-Embodied-AI merged 1 commit intoGenesis-Embodied-AI:mainfrom
hughperkins:hp/flush-benchmarking-results

Conversation

@hughperkins
Copy link
Collaborator

Description

Flush benchmarking results after each test

Related Issue

Resolves Genesis-Embodied-AI/Genesis#
Resolves #1332

Motivation and Context

Having to wait until all benchmarking tests have run in order to see the results

How Has This Been / Can This Be Tested?

Running the benchmark script

pytest -svx tests/test_rigid_benchmarks.py -m benchmarks -sv

Screenshots (if appropriate):

Checklist:

  • I read the CONTRIBUTING document.
  • I followed the Submitting Code Changes section of CONTRIBUTING document.
  • I tagged the title correctly (including BUG FIX/FEATURE/MISC/BREAKING)
  • I updated the documentation accordingly or no change is needed.
  • I tested my changes and added instructions on how to test it for reviewers.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@duburcqa
Copy link
Collaborator

duburcqa commented Jun 28, 2025

Are you sure it changes anything ? I’m surprised. If you have a single GPU, you could just do:
pytest --print -x -n 0 -m 'benchmarks' ./tests

@hughperkins
Copy link
Collaborator Author

It definitely changes the output to that file. Because I tried it multiple times without, and had to wait 30 minutes to find out stuff wasnt working etc. And with, then eaach test outputs immediately.

@Genesis-Embodied-AI Genesis-Embodied-AI merged commit 7cf9efe into Genesis-Embodied-AI:main Jun 29, 2025
13 checks passed
Milotrince pushed a commit to Milotrince/Genesis that referenced this pull request Jul 5, 2025
chris-la-humalab pushed a commit to HumaLab/Genesis that referenced this pull request Aug 1, 2025
YilingQiao pushed a commit to YilingQiao/Genesis that referenced this pull request Aug 22, 2025
@hughperkins hughperkins deleted the hp/flush-benchmarking-results branch January 20, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Benchmarking results are not being flushed to disk until the end of all tests

3 participants