[FEATURE] Add 'get_weld_constraints' API.#1370
Merged
duburcqa merged 30 commits intoGenesis-Embodied-AI:mainfrom Aug 10, 2025
Merged
[FEATURE] Add 'get_weld_constraints' API.#1370duburcqa merged 30 commits intoGenesis-Embodied-AI:mainfrom
duburcqa merged 30 commits intoGenesis-Embodied-AI:mainfrom
Conversation
672a192 to
00f2534
Compare
00f2534 to
c176525
Compare
duburcqa
requested changes
Jul 8, 2025
duburcqa
reviewed
Jul 9, 2025
duburcqa
reviewed
Jul 11, 2025
duburcqa
reviewed
Jul 11, 2025
|
Too much additions leads to error |
Collaborator
|
@LeonLiu4 can you merge the latest main? You might need to modify the kernel a little bit to adapt to the new struct of array access pattern |
Collaborator
|
@davidhommie can you provide a script? Or a link to the issue you mentioned? |
YilingQiao
previously approved these changes
Aug 4, 2025
duburcqa
reviewed
Aug 8, 2025
duburcqa
reviewed
Aug 8, 2025
duburcqa
reviewed
Aug 8, 2025
duburcqa
reviewed
Aug 8, 2025
duburcqa
reviewed
Aug 8, 2025
duburcqa
reviewed
Aug 8, 2025
duburcqa
reviewed
Aug 8, 2025
duburcqa
reviewed
Aug 8, 2025
duburcqa
reviewed
Aug 8, 2025
|
Folks, maybe you would merge a basic version of this? It's been a month since #1365. I currently have to write strange logic to assert weld constraints existence in my tests, e.g. moving a part by an arbitrary distance, and asserting that welded parts have to be equally moved. |
duburcqa
approved these changes
Aug 10, 2025
Collaborator
|
@MRiabov I understand your frustration but we only merge features when it is ready, and we were busy with other features during the last few weeks. |
YilingQiao
pushed a commit
to YilingQiao/Genesis
that referenced
this pull request
Aug 22, 2025
winnieyangwannan
pushed a commit
to winnieyangwannan/Genesis
that referenced
this pull request
Sep 14, 2025
Kashu7100
pushed a commit
to Kashu7100/Genesis
that referenced
this pull request
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds RigidSolver.get_weld_constraints() – returns an (N, 3) NumPy array (env_id, link1_idx, link2_idx) of all active weld constraints, enabling quick inspection and test assertions without poking internal Taichi fields.
Resolves #1365