[FEATURE] expose joint position query#1385
[FEATURE] expose joint position query#1385Kashu7100 wants to merge 1 commit intoGenesis-Embodied-AI:mainfrom
Conversation
|
Can you explain what is the use-case for this? As already discussed several times in the past, I think exposing the “position” of joints is a bad idea because it is error prone. Most of the user will not understand what this is and will use it incorrectly. In my view, only link and geom poses should be exposed to the user. |
|
I was thinking of using this when I convert some code using different simulator but I think I can use the links to do the same! |
|
(Maybe) |
|
Now that I remember, there is already |
| @gs.assert_built | ||
| def get_joints_anchor_pos(self, joints_idx_local=None, envs_idx=None, *, unsafe=False): | ||
| """ | ||
| Returns anchor position of the entity's joints. This is the position of the joint in the world frame. |
There was a problem hiding this comment.
This means nothing: "This is the position of the joint in the world frame."
There was a problem hiding this comment.
Here is the actual definition:
|
After think twice, maybe we could factorize the implementations at joint-level with what you did? If you do so, I'm open to merge it! |
|
Closing since there has been no activity since quite a while. |
Description
Add two new API
get_joints_anchor_posandget_joints_anchor_axisthat returns the joint position in world coordinate and the axis direction in unit vector.Related Issue
Resolves Genesis-Embodied-AI/Genesis#
Motivation and Context
How Has This Been / Can This Be Tested?
Screenshots (if appropriate):
Checklist:
Submitting Code Changessection of CONTRIBUTING document.