[FEATURE] Enabling rendering plane geometry one-sided.#1396
Merged
duburcqa merged 26 commits intoGenesis-Embodied-AI:mainfrom Jul 15, 2025
Merged
[FEATURE] Enabling rendering plane geometry one-sided.#1396duburcqa merged 26 commits intoGenesis-Embodied-AI:mainfrom
duburcqa merged 26 commits intoGenesis-Embodied-AI:mainfrom
Conversation
duburcqa
reviewed
Jul 10, 2025
duburcqa
reviewed
Jul 14, 2025
duburcqa
reviewed
Jul 14, 2025
duburcqa
reviewed
Jul 14, 2025
duburcqa
reviewed
Jul 14, 2025
duburcqa
changed the title
duburcqa
changed the title
Collaborator
|
Is this patch all that was needed to fix one-sided plane?! That would be awesome :) |
Contributor
Author
Unfortunately that patch created a mesh that was not a solid volume causing there to be errors with stuff like collisions. However I have rectified that by differentiating between a visual and collision mesh |
Collaborator
|
@LeonLiu4 Can you confirm this PR is ready to merge and the videos in description are still valid? |
duburcqa
approved these changes
Jul 15, 2025
Contributor
Author
Yes the videos are correct and its ready to merge |
chris-la-humalab
pushed a commit
to HumaLab/Genesis
that referenced
this pull request
Aug 1, 2025
LeonLiu4
added a commit
to LeonLiu4/Genesis
that referenced
this pull request
Aug 7, 2025
YilingQiao
pushed a commit
to YilingQiao/Genesis
that referenced
this pull request
Aug 22, 2025
winnieyangwannan
pushed a commit
to winnieyangwannan/Genesis
that referenced
this pull request
Sep 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create_plane() now accepts double_sided (default false), returning a single-sided quad with the same footprint/UVs.
Addresses #1112
Two sided:
Screen.Recording.2025-07-11.at.8.54.52.PM.mov
One sided:
Screen.Recording.2025-07-11.at.8.55.35.PM.mov