Skip to content

[DO NOT MERGE] Test Batch renderer macos fix#1489

Closed
yuhongyi wants to merge 46 commits intomainfrom
batch-renderer-macos-fix
Closed

[DO NOT MERGE] Test Batch renderer macos fix#1489
yuhongyi wants to merge 46 commits intomainfrom
batch-renderer-macos-fix

Conversation

@yuhongyi
Copy link
Contributor

@yuhongyi yuhongyi commented Aug 2, 2025

Description

Related Issue

Resolves Genesis-Embodied-AI/Genesis#

Motivation and Context

How Has This Been / Can This Be Tested?

Screenshots (if appropriate):

Checklist:

  • I read the CONTRIBUTING document.
  • I followed the Submitting Code Changes section of CONTRIBUTING document.
  • I tagged the title correctly (including BUG FIX/FEATURE/MISC/BREAKING)
  • I updated the documentation accordingly or no change is needed.
  • I tested my changes and added instructions on how to test it for reviewers.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

yuhongyi and others added 30 commits June 26, 2025 12:51
Create tuples directly in BatchRender.render()

Check input_types in Camera.set_pose() with set

Update comments in batch_render.py and scene.py
* Improve math formulas and comments

* Simplify the math to do y-forward quaternion transform

* Black format scene.py and camera.py

* Refactor ImageExporter to handle RGB and Depth separately with partial function

* Black format image_exporter.py and batch_renderer.py
* Genesis now passes render_options to Madrona to specify the which outputs to generate, including RGB and Depth for now

* Black format batch_renderer.py
…tiple environments (#4)

* Fix transform issue with camera.set_pose by supporting batch transform with z_up_to_R

Optimize quaternion transform of camera with Taichi kernel

* Format files with black

* Optimize R_to_quat
Create tuples directly in BatchRender.render()

Check input_types in Camera.set_pose() with set

Update comments in batch_render.py and scene.py
* Improve math formulas and comments

* Simplify the math to do y-forward quaternion transform

* Black format scene.py and camera.py

* Refactor ImageExporter to handle RGB and Depth separately with partial function

* Black format image_exporter.py and batch_renderer.py
* Genesis now passes render_options to Madrona to specify the which outputs to generate, including RGB and Depth for now

* Black format batch_renderer.py
… wrong. It uses nenvs as index to be passed to attach. With the new implementation, index is not required. With batch rendering, cameras attached to links can be updated for each environment.
@duburcqa duburcqa closed this Aug 2, 2025
@duburcqa duburcqa deleted the batch-renderer-macos-fix branch August 2, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants