[MISC] Remove fast_simplification submodule.#1497
Merged
duburcqa merged 8 commits intoGenesis-Embodied-AI:mainfrom Aug 5, 2025
Merged
[MISC] Remove fast_simplification submodule.#1497duburcqa merged 8 commits intoGenesis-Embodied-AI:mainfrom
duburcqa merged 8 commits intoGenesis-Embodied-AI:mainfrom
Conversation
duburcqa
requested changes
Aug 4, 2025
duburcqa
changed the title
duburcqa
previously approved these changes
Aug 4, 2025
duburcqa
changed the title
duburcqa
approved these changes
Aug 4, 2025
YilingQiao
pushed a commit
to YilingQiao/Genesis
that referenced
this pull request
Aug 22, 2025
winnieyangwannan
pushed a commit
to winnieyangwannan/Genesis
that referenced
this pull request
Sep 14, 2025
Kashu7100
added a commit
to Kashu7100/Genesis
that referenced
this pull request
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Having to compile
fast_simplificationsubmodule from source when building wheels for Genesis forces to distribute platform-specific pre-compiled binaries on PyPI. This is tedious and not worth the effort considering how limited is the benefit of maintaining our own version of 'fast_simplication' library. It is only exposing lossless simplification, which could be easily contributed upstream directly.Checklist:
Submitting Code Changessection of CONTRIBUTING document.