Skip to content

[FEATURE] Support 2-channel (LA) textures in Rasterizer.#1519

Merged
duburcqa merged 5 commits intoGenesis-Embodied-AI:mainfrom
LeonLiu4:fix/channel
Aug 9, 2025
Merged

[FEATURE] Support 2-channel (LA) textures in Rasterizer.#1519
duburcqa merged 5 commits intoGenesis-Embodied-AI:mainfrom
LeonLiu4:fix/channel

Conversation

@LeonLiu4
Copy link
Contributor

@LeonLiu4 LeonLiu4 commented Aug 7, 2025

This PR updates genesis/ext/pyrender/utils.py to convert 2-channel (luminance+alpha) textures into RGB (by dropping alpha and replicating luminance) or RGBA (by mapping luminance to RGB and preserving alpha), instead of raising an error.

Resolves #1476

Screenshot 2025-08-07 at 12 22 48 PM ^the fridge now

Copy link
Collaborator

@duburcqa duburcqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a unit test for the fridge ? Just to make sure it is properly loaded ? The asset should be uploaded on Hugging Face.

@duburcqa
Copy link
Collaborator

duburcqa commented Aug 9, 2025

The assets should be added on huggingface repository, not in Genesis assets.

@duburcqa duburcqa force-pushed the fix/channel branch 2 times, most recently from a78c0a8 to b9efc3c Compare August 9, 2025 17:42
duburcqa
duburcqa previously approved these changes Aug 9, 2025
@duburcqa duburcqa enabled auto-merge (squash) August 9, 2025 17:42
@duburcqa duburcqa disabled auto-merge August 9, 2025 17:43
@duburcqa duburcqa enabled auto-merge (squash) August 9, 2025 17:44
@duburcqa duburcqa changed the title [FEATURE] Support 2-channel (LA) textures in Pyrender utils [FEATURE] Support 2-channel (LA) textures in Rasterizer. Aug 9, 2025
@duburcqa duburcqa merged commit f823d6a into Genesis-Embodied-AI:main Aug 9, 2025
18 checks passed
winnieyangwannan pushed a commit to winnieyangwannan/Genesis that referenced this pull request Sep 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: ValueError: Cannot reformat 2-channel texture into RGBA

2 participants