[MISC] Migrate to native Python API for 'splashsurf'.#1531
Merged
duburcqa merged 1 commit intoGenesis-Embodied-AI:mainfrom Aug 10, 2025
Merged
[MISC] Migrate to native Python API for 'splashsurf'.#1531duburcqa merged 1 commit intoGenesis-Embodied-AI:mainfrom
duburcqa merged 1 commit intoGenesis-Embodied-AI:mainfrom
Conversation
duburcqa
force-pushed
the
native_splashsurf
branch
from
ef8c968 to
716fb4f
Compare
duburcqa
force-pushed
the
native_splashsurf
branch
from
716fb4f to
1e2811e
Compare
duburcqa
force-pushed
the
native_splashsurf
branch
from
1e2811e to
70ae3d0
Compare
YilingQiao
approved these changes
Aug 10, 2025
YilingQiao
pushed a commit
to YilingQiao/Genesis
that referenced
this pull request
Aug 22, 2025
|
@duburcqa It will probably not make a big difference but I would recommend you to use vertices, triangles = mesh_with_data.take_mesh().take_vertices_and_triangles()to move the data out of the mesh (here: (https://github.com/duburcqa/Genesis/blob/70ae3d0d65e96b74bc36ceb1a76e905f541e7edf/genesis/utils/particle.py#L352)) - this avoids a copy which is otherwise necessary at the moment for the getters. I will probably rename/replace the getters in the future to make this more obvious. |
Collaborator
Author
|
@w1th0utnam3 Thank you! I will do this 👍 |
winnieyangwannan
pushed a commit
to winnieyangwannan/Genesis
that referenced
this pull request
Sep 14, 2025
Kashu7100
pushed a commit
to Kashu7100/Genesis
that referenced
this pull request
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Resolves #1523
Resolves #1524
Motivation and Context
How Has This Been / Can This Be Tested?
Screenshots (if appropriate):
Checklist:
Submitting Code Changessection of CONTRIBUTING document.