[MISC] Rename taichi => gstaichi#1532
[MISC] Rename taichi => gstaichi#1532hughperkins wants to merge 2 commits intoGenesis-Embodied-AI:mainfrom
Conversation
| - [GsTaichi](https://github.com/taichi-dev/gstaichi):提供高性能跨平台计算后端。感谢 gstaichi 的所有成员提供的技术支持! | ||
| - [FluidLab](https://github.com/zhouxian/FluidLab) 提供参考 MPM 求解器实现 | ||
| - [SPH_Taichi](https://github.com/erizmr/SPH_Taichi) 提供参考 SPH 求解器实现 | ||
| - [SPH_GsTaichi](https://github.com/erizmr/SPH_GsTaichi) 提供参考 SPH 求解器实现 |
There was a problem hiding this comment.
should probably be careful with urls 🤔 Might be able to update the script to handle those somehow perhaps 🤔
There was a problem hiding this comment.
(otherwise could just add them case-by-case to the script)
|
I am not sure how easy it is but is it possible to import as |
This would cause conflicts if someone installed both Considering that many people installing Genesis are likely doing an upgrade from an earlier installation of Genesis, they will already have |
|
|
||
| Genesis's development has been made possible thanks to these open-source projects: | ||
|
|
||
| - [GsTaichi](https://github.com/taichi-dev/gstaichi): High-performance cross-platform compute backend. Kudos to the GsTaichi team for their technical support! |
There was a problem hiding this comment.
As stated above, we should probably be careful with URLs somehow, yes. Eg hardcode them inssdie the migration script, case by case.
|
|
||
| - [GsTaichi](https://github.com/taichi-dev/gstaichi): High-performance cross-platform compute backend. Kudos to the GsTaichi team for their technical support! | ||
| - [FluidLab](https://github.com/zhouxian/FluidLab): Reference MPM solver implementation. | ||
| - [SPH_GsTaichi](https://github.com/erizmr/SPH_GsTaichi): Reference SPH solver implementation. |
There was a problem hiding this comment.
No need to change this file.
There was a problem hiding this comment.
The script changes all files. If you prefer to make the minimum changes necessary, this scripted approach might not be the best approach for you.
| * Add GJK-EPA algorithm for rigid body collision detection. (@SonSang) (#1213, #1357) | ||
| * Add linear_corotated elastic material for FEM. (@Libero0809) (#1304) | ||
| * Add fast vs high-performance taichi compilation mode. (@hughperkins) (#1330) | ||
| * Add fast vs high-performance gstaichi compilation mode. (@hughperkins) (#1330) |
There was a problem hiding this comment.
why is this wrong? 🤔
There was a problem hiding this comment.
Because it is related to an old PR that was based on taichi.
| * Fix genesis destroy. (@duburcqa) (#1007) | ||
| * Fix issue when adding multiple FEM entities. (@kosuke1701) (#1014) | ||
| * Using Vulkan backend for taichi even if no Intel XPU device is available. (@duburcqa) (#1025) | ||
| * Using Vulkan backend for gstaichi even if no Intel XPU device is available. (@duburcqa) (#1025) |
There was a problem hiding this comment.
why is this wrong? 🤔
There was a problem hiding this comment.
Same reason. Old PR based on taichi.
| pytestmark = [ | ||
| pytest.mark.benchmarks, | ||
| pytest.mark.taichi_offline_cache(False), | ||
| pytest.mark.gstaichi_offline_cache(False), |
|
|
||
| else: | ||
| raise NotImplementedError(f"Taichi func with arity in={num_inputs},out={num_outputs} not supported") | ||
| raise NotImplementedError(f"GsTaichi func with arity in={num_inputs},out={num_outputs} not supported") |
| def test_utils_geom_taichi_vs_tensor_consistency(batch_shape): | ||
| import taichi as ti | ||
| def test_utils_geom_gstaichi_vs_tensor_consistency(batch_shape): | ||
| import gstaichi as ti |
| def test_utils_geom_taichi_inverse(batch_shape): | ||
| import taichi as ti | ||
| def test_utils_geom_gstaichi_inverse(batch_shape): | ||
| import gstaichi as ti |
| def test_utils_geom_taichi_identity(batch_shape): | ||
| import taichi as ti | ||
| def test_utils_geom_gstaichi_identity(batch_shape): | ||
| import gstaichi as ti |
|
I thought I'd closed this, but for some reason seem not to have 🤔 @duburcqa and I discussed that the approach in this PR causes far too many renames, and a much lighter weight approach - only changing the imports - could be appropriate. |
Description
Related Issue
Resolves Genesis-Embodied-AI/Genesis#
Motivation and Context
How Has This Been / Can This Be Tested?
ran
TI_LOG_LEVEL=trace python examples/rigid/single_franka_envs.py -n 2 --horizon 2once. It didnt crash.Screenshots (if appropriate):
Checklist:
Submitting Code Changessection of CONTRIBUTING document.