Skip to content

[BUG FIX] Fix video recording dialog when running viewer in thread. #1547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
duburcqa merged 1 commit into from
Aug 12, 2025
Merged

[BUG FIX] Fix video recording dialog when running viewer in thread. #1547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions genesis/ext/pyrender/viewer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1045,14 +1045,22 @@ def _get_save_filename(self, file_exts):
"all": ("all files", "*"),
}
filetypes = [file_types[x] for x in file_exts]
save_dir = self.viewer_flags["save_directory"]
if save_dir is None:
save_dir = os.getcwd()
try:
save_dir = self.viewer_flags["save_directory"]
if save_dir is None:
save_dir = os.getcwd()
filename = filedialog.asksaveasfilename(
initialdir=save_dir, title="Select file save location", filetypes=filetypes
master = None
if self._run_in_thread:
master = Tk()
master.withdraw()
dialog = filedialog.SaveAs(
master=master, initialdir=save_dir, title="Select file save location", filetypes=filetypes
)
filename = dialog.show()
if self._run_in_thread:
master.destroy()
except Exception:
gs.logger.warning("Failed to open file save location dialog.")
return None

if not filename:
Expand Down