[BUG FIX] More robust handling of corrupted cache.#2241
Merged
duburcqa merged 1 commit intoGenesis-Embodied-AI:mainfrom Jan 15, 2026
Merged
[BUG FIX] More robust handling of corrupted cache.#2241duburcqa merged 1 commit intoGenesis-Embodied-AI:mainfrom
duburcqa merged 1 commit intoGenesis-Embodied-AI:mainfrom
Conversation
hughperkins
reviewed
Jan 15, 2026
| gsd_dict = pkl.load(file) | ||
| is_cached_loaded = True | ||
| except (EOFError, ModuleNotFoundError, pkl.UnpicklingError): | ||
| except (EOFError, ModuleNotFoundError, pkl.UnpicklingError, TypeError, MemoryError): |
Collaborator
There was a problem hiding this comment.
should we delete the corrupted cache file?
Collaborator
Author
There was a problem hiding this comment.
No because we are going to overwrite it right away.
Collaborator
There was a problem hiding this comment.
Note: for all those test failures you're seeing, I'm adding retry here:
example success:
|
🔴 Benchmark Regression Detected ➡️ Report |
Kashu7100
pushed a commit
to Kashu7100/Genesis
that referenced
this pull request
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.