Skip to content

[BUG FIX] Clamp BatchRenderer deferred RGB packing #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
duburcqa merged 2 commits into from
Jul 22, 2026
Merged

[BUG FIX] Clamp BatchRenderer deferred RGB packing #57

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a63c53a
Clamp deferred RGB values before packing
NoahLinckeScout Jul 15, 2026
413280a
Cast alpha byte to uint32_t in deferred RGB packing
duburcqa Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/render/shaders/draw_deferred_rgb.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,9 @@ float calculateLinearDepth(float depth_in, uint view_idx)

uint32_t float3ToUint32(float3 v)
{
return (uint32_t)(v.x * 255.0f) | ((uint32_t)(v.y * 255.0f) << 8) | ((uint32_t)(v.z * 255.0f) << 16) | (255 << 24);
// Deferred RGB is LDR; tone-map HDR lighting before packing it into bytes.
uint3 quant = (uint3)(255.0f * clamp(v, 0.0f, 1.0f));
return quant.r | (quant.g << 8) | (quant.b << 16) | ((uint32_t)255 << 24);
}

float linearToSRGB(float v)
Expand Down
Loading