Skip to content

[Build] Build using freshly built LLVM 15.0.7 - #216

Merged
hughperkins merged 9 commits into
mainfrom
hp/self-built-llvm
Oct 7, 2025
Merged

[Build] Build using freshly built LLVM 15.0.7#216
hughperkins merged 9 commits into
mainfrom
hp/self-built-llvm

Conversation

@hughperkins

@hughperkins hughperkins commented Sep 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Issue: #

Brief Summary

  • use llvm built from gstaichi-sdk-builds
  • switch to building linux using gcc

Genesis tests ran to completion Genesis-Embodied-AI/genesis-world#1762

(Not sure if any effect on performance. @duburcqa ?)

copilot:summary

Walkthrough

copilot:walkthrough

@hughperkins hughperkins changed the title [Build] Build using fresly built LLVM 15.0.7 [Build] Build using freshly built LLVM 15.0.7 Sep 21, 2025
hughperkins
hughperkins commented Sep 21, 2025
View reviewed changes
Comment thread .github/workflows/manylinux_wheel.yml
PYTHON_VERSION: '3.12'
- PYTHON_CP_VERSION: 'cp313'
PYTHON_VERSION: '3.13'
PYTHON_VERSION: ['3.10', '3.11', '3.12', '3.13']

@hughperkins hughperkins Sep 21, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cleaned this up a bit. This isnt necessary, but seemed worth doing.

hughperkins
hughperkins commented Sep 21, 2025
View reviewed changes
Comment thread cmake/GsTaichiCore.cmake

if (LINUX)
target_link_libraries(${CORE_LIBRARY_NAME} PRIVATE X11 pthread)
target_link_libraries(${CORE_LIBRARY_NAME} PRIVATE pthread)

@hughperkins hughperkins Sep 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed superflous x11. not strictly necesssary, but since. I noticed it.

hughperkins
hughperkins commented Sep 21, 2025
View reviewed changes
Comment thread misc/ci_setup.py Outdated
execute_command("sudo apt-get update")
if self.build_type == "ci":
execute_command("sudo apt-get install -y python3-dev libx11-dev")
execute_command("sudo apt-get install -y python3-dev")

@hughperkins hughperkins Sep 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed superflous x11. not strictly necesssary, but since. I noticed it.

@hughperkins
hughperkins marked this pull request as ready for review September 21, 2025 19:39
@hughperkins hughperkins mentioned this pull request Sep 24, 2025
Closed
@hughperkins

hughperkins commented Oct 4, 2025

Copy link
Copy Markdown
Collaborator Author

Note that Genesis passes benchmarks, using this branch, Genesis-Embodied-AI/genesis-world#1762

@hughperkins

hughperkins commented Oct 7, 2025

Copy link
Copy Markdown
Collaborator Author

Thanks!

@hughperkins
hughperkins enabled auto-merge (squash) October 7, 2025 03:13
@hughperkins
hughperkins disabled auto-merge October 7, 2025 03:15
@hughperkins

hughperkins commented Oct 7, 2025

Copy link
Copy Markdown
Collaborator Author

Did a binary search over llvm builds:

202509261351 => fail
202509261125 => fail
202509212040 => ok

202509202046 => ok

@duburcqa

duburcqa commented Oct 7, 2025

Copy link
Copy Markdown
Contributor

Binary search for what? I must have missed something

@hughperkins

hughperkins commented Oct 7, 2025 via email

Copy link
Copy Markdown
Collaborator Author

@hughperkins

hughperkins commented Oct 7, 2025

Copy link
Copy Markdown
Collaborator Author

Fixed in Genesis-Embodied-AI/quadrants-sdk-builds#12

Will wait for that to be merged, then do a non-pre-release llvm build, and update this branch to use the updated non-pre-release llvm build.

@hughperkins
hughperkins merged commit 195157f into main Oct 7, 2025
47 checks passed
@hughperkins
hughperkins deleted the hp/self-built-llvm branch October 7, 2025 15:43
@hughperkins

hughperkins commented Oct 7, 2025

Copy link
Copy Markdown
Collaborator Author

Yay! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CharlesMasson CharlesMasson CharlesMasson approved these changes
@duburcqa duburcqa duburcqa approved these changes
@erizmr erizmr erizmr approved these changes
@YilingQiao YilingQiao YilingQiao approved these changes

Assignees

@CharlesMasson CharlesMasson

@duburcqa duburcqa

@erizmr erizmr

@YilingQiao YilingQiao

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hughperkins @duburcqa @CharlesMasson @erizmr @YilingQiao