Skip to content

Review html templates #2047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Review html templates #2047

wants to merge 2 commits into from

Conversation

dsuren1
Copy link

@dsuren1 dsuren1 commented May 12, 2025 •
edited
Loading

Description

This PR removes unused html templates and it's references

@dsuren1 dsuren1 added this to the 5.0.0 milestone May 12, 2025
@dsuren1 dsuren1 requested a review from allyoucanmap May 12, 2025 10:39
@dsuren1 dsuren1 self-assigned this May 12, 2025
@dsuren1 dsuren1 added enhancement New feature or request master geonode-ui labels May 12, 2025
allyoucanmap
allyoucanmap requested changes May 16, 2025
View reviewed changes
Copy link
Collaborator

@allyoucanmap allyoucanmap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resource_card.html and resources_grid.html should not be removed but instead replaced using new classes and structure

allyoucanmap
allyoucanmap reviewed May 16, 2025
View reviewed changes
Copy link
Collaborator

@allyoucanmap allyoucanmap left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We removed the code from the topbar including the menu items, we should port that logic on the brand navbar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allyoucanmap allyoucanmap allyoucanmap requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@dsuren1 dsuren1

Labels
enhancement New feature or request geonode-ui master
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dsuren1 @allyoucanmap