Fix - Actionbar menus are hidden behind the document viewer #2048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allyoucanmap
requested changes
May 16, 2025
| @@ -32,7 +32,6 @@ | |||
| justify-content: center; | |||
| font-size: 14px; | |||
| flex-direction: column; | |||
| z-index: 100; | |||
There was a problem hiding this comment.
The .gn-main-event-container is used by multiple components including global loaders and feeback messages so I would prefer to not change this.
The other strange thins is the used of .gn-main-event-container inside the MetadataPreview component.
I would prefer we have a dedicated className and use of utility classes:
import FlexBox from '@mapstore/framework/components/layout/FlexBox';
import React from 'react';
function MetadataPreview({
url
}) {
return (
<FlexBox column centerChildren classNames={['gn-metadata-preview', '_corner-tl', '_absolute', '_fill']}>
<iframe
frameBorder="0"
key={url}
src={url}
style={{
width: '100%',
height: '100%'
}} />
</FlexBox>
);
}
please check if this is working as expected
There was a problem hiding this comment.
Works fine. Thanks!
Also fixed a couple of issues when adhoc testing
- Hide footer placeholder in viewer page
- download menu button alignment
allyoucanmap
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the menu items hidden in viewer
Screenshot