Reset pending changes on viewer page change #2070
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| initStyleService(), | ||
| resetStyleEditor() | ||
| ]; | ||
| const getResetActions = (state, isSameResource) => { |
There was a problem hiding this comment.
get action is used multiple times in this code so before was assuming isSameResource as for argument. Shouldn't we review also other places where getResetActions is used?
There was a problem hiding this comment.
getResetActions is used in other scenarios that require a full reset—such as creating a new resource or handling an error—where the resource is not the same. The only case where the isSameResource argument is needed is when loading an existing resource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue where pending changes were retained when navigating away from the page causing unwanted side effects