Skip to content

Conversation

@allyoucanmap
Copy link
Collaborator

The submodule has been updated to master and Itinerary and Isochrone plugins included. Both plugins needs to be configured in a map viewer to be enabled and a valid graphhopper url endpoint must be provided:

2025-09-24 10_10_46-Window 2025-09-24 10_11_18-Window 2025-09-24 10_17_29-Window 2025-09-24 10_15_04-Window

@allyoucanmap allyoucanmap added this to the 5.0.0 milestone Sep 24, 2025
@allyoucanmap allyoucanmap self-assigned this Sep 24, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @allyoucanmap, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the core MapStore2 submodule to its latest master branch, which is a significant dependency upgrade. The primary impact of this update is the introduction and enablement of new mapping functionalities, specifically the Itinerary and Isochrone plugins for route planning and area analysis, as well as a SecurityPopup plugin. These changes ensure the application can leverage the most recent features and improvements from MapStore2 and provides users with enhanced geospatial tools.

Highlights

  • MapStore2 Submodule Update: The MapStore2 submodule has been updated to point to the master branch, bringing in the latest changes and features from the upstream repository. This includes an update to the specific commit hash from 8bcd0ab to 52891c7.
  • New Plugin Integration: The Itinerary and Isochrone navigation plugins, along with a SecurityPopup plugin, have been integrated into the application. These plugins are now imported and registered in the client-side plugin index.
  • Plugin Configuration: Configuration entries for the newly integrated Itinerary, Isochrone, and SecurityPopup plugins have been added to pluginsConfig.json, making them available for use and configuration within the application's map viewer.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the MapStore2 submodule to its master branch, introducing the Isochrone, Itinerary, and SecurityPopup plugins. The changes correctly integrate these new plugins by adding them to the plugin index and providing their configurations. My review focuses on improving long-term stability and maintainability. I've raised a high-severity concern about using a floating master branch for the submodule, which can introduce instability. I've also provided medium-severity suggestions to improve code readability by sorting the new imports and plugin declarations alphabetically.

allyoucanmap and others added 3 commits September 24, 2025 10:41
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@allyoucanmap allyoucanmap merged commit 7d8b6b5 into master Sep 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants