Skip to content

Conversation

@giohappy
Copy link

No description provided.

@giohappy giohappy linked an issue Jan 15, 2026 that may be closed by this pull request
@gemini-code-assist
Copy link

Summary of Changes

Hello @giohappy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modernizes the project's packaging and build system by migrating from traditional setup.py, setup.cfg, and requirements.txt files to a unified pyproject.toml configuration. This change streamlines dependency management, standardizes project metadata, and aligns the project with current Python ecosystem best practices, improving maintainability and compatibility.

Highlights

  • Migration to pyproject.toml: The project configuration has been migrated from setup.py and setup.cfg to a single pyproject.toml file, adopting the modern standard for Python project metadata and build system configuration.
  • Dependency Management Consolidation: Project dependencies, previously listed in requirements.txt and setup.cfg, are now centrally managed within the pyproject.toml file.
  • Build System Configuration: The pyproject.toml file now defines the build system using setuptools and wheel, along with project metadata such as name, description, authors, license, and classifiers.
  • Flake8 Configuration: Flake8 linting rules, including max-line-length and exclude paths, have been moved from setup.cfg to the [tool.flake8] section within pyproject.toml.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully migrates the project's packaging configuration from setup.py, setup.cfg, and requirements.txt to a modern pyproject.toml file. This is a great modernization effort that also fixes a minor bug in the previous setup.py where only the first line of the README was used as the long description.

I have two main points of feedback:

  1. There is a significant, undocumented breaking change in the minimum required Python version, which has been raised from 3.7 to 3.10. This needs to be communicated.
  2. The project's Download URL could be improved to point to stable releases.

Please see the specific comments for details.

name = "django-geonode-mapstore-client"
description = "Use GeoNode client in your django projects"
readme = { file = "README.md", content-type = "text/markdown" }
requires-python = ">=3.10"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The minimum required Python version has been updated to >=3.10 from 3.7 in the previous setup.cfg. This is a significant breaking change that should be clearly communicated in the pull request description and project's release notes to avoid issues for users on older Python versions.


[project.urls]
Homepage = "https://github.com/GeoNode/geonode-mapstore-client"
Download = "https://github.com/GeoNode/geonode-mapstore-client/tarball/master"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Download URL points to a tarball of the master branch. This URL provides the latest development code, not a stable release. It's better practice to point to the GitHub releases page where users can find stable, versioned packages.

Suggested change
Download = "https://github.com/GeoNode/geonode-mapstore-client/tarball/master"
Download = "https://github.com/GeoNode/geonode-mapstore-client/releases"

@giohappy giohappy merged commit 58a007c into master Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch to pyproject.toml

3 participants