-
Notifications
You must be signed in to change notification settings - Fork 127
[Fixes #2322] Switch to pyproject #2323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @giohappy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the project's packaging and build system by migrating from traditional Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully migrates the project's packaging configuration from setup.py, setup.cfg, and requirements.txt to a modern pyproject.toml file. This is a great modernization effort that also fixes a minor bug in the previous setup.py where only the first line of the README was used as the long description.
I have two main points of feedback:
- There is a significant, undocumented breaking change in the minimum required Python version, which has been raised from 3.7 to 3.10. This needs to be communicated.
- The project's
DownloadURL could be improved to point to stable releases.
Please see the specific comments for details.
| name = "django-geonode-mapstore-client" | ||
| description = "Use GeoNode client in your django projects" | ||
| readme = { file = "README.md", content-type = "text/markdown" } | ||
| requires-python = ">=3.10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| [project.urls] | ||
| Homepage = "https://github.com/GeoNode/geonode-mapstore-client" | ||
| Download = "https://github.com/GeoNode/geonode-mapstore-client/tarball/master" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Download URL points to a tarball of the master branch. This URL provides the latest development code, not a stable release. It's better practice to point to the GitHub releases page where users can find stable, versioned packages.
| Download = "https://github.com/GeoNode/geonode-mapstore-client/tarball/master" | |
| Download = "https://github.com/GeoNode/geonode-mapstore-client/releases" |
No description provided.