[Fixies #12540] PyCSW upgrade to version 3 #13112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13112 +/- ##
==========================================
- Coverage 72.59% 72.59% -0.01%
==========================================
Files 916 916
Lines 52636 52636
Branches 6058 6058
==========================================
- Hits 38213 38210 -3
- Misses 12857 12860 +3
Partials 1566 1566 🚀 New features to boost your workflow:
|
etj
reviewed
May 21, 2025
| "pycsw:AnyText": "csw_anytext", | ||
| "pycsw:Language": "language", | ||
| "pycsw:Title": "title", | ||
| "pycsw:Abstract": "raw_abstract", | ||
| "pycsw:Edition": "csw_edition", |
There was a problem hiding this comment.
ResourceBase has an edition field, not csw_edition
edition = models.CharField(_("edition"), max_length=255, blank=True, null=True, help_text=edition_help_text)
requirements.txt
Outdated
| @@ -52,13 +52,14 @@ oauthlib==3.2.2 | |||
| pyjwt==2.8.0 | |||
|
|
|||
| # geopython dependencies | |||
| git+https://github.com/geopython/pycsw.git@master#egg=pycsw | |||
There was a problem hiding this comment.
master is a bit too dynamic, we may want a tagged version (3.0.0-beta1 is the latest)
setup.cfg
Outdated
| @@ -80,11 +80,12 @@ install_requires = | |||
| # geopython dependencies | |||
| pyproj<3.7.0 | |||
| OWSLib==0.31.0 | |||
| pycsw==2.6.1 | |||
| pycsw @ git+https://github.com/geopython/pycsw.git@master#egg=pycsw | |||
There was a problem hiding this comment.
as above: master is a bit too dynamic, we may want a tagged version (3.0.0-beta1 is the latest)
| @@ -28,24 +28,29 @@ | |||
| "pycsw:MdSource": "csw_mdsource", | |||
| "pycsw:InsertDate": "csw_insert_date", | |||
| "pycsw:XML": "metadata_xml", | |||
| "pycsw:Metadata": "metadata", | |||
There was a problem hiding this comment.
Should probably be metadata_xml since in pycsw doc:
pycsw:XML: full XML representation (deprecated; will be removed in a future release)pycsw:Metadata: full metadata representation
There was a problem hiding this comment.
As we discussed, I left it as it for now
giohappy
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created according to this issue: #12540 . There is an older PR here: #12535 but a new one was created due to significant changes on the master branch since the previous PR — including the addition of the new metadata editor.
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.