Skip to content

Conversation

@alanjyu
Copy link
Contributor

@alanjyu alanjyu commented Dec 11, 2024

Add the required modules for compiling the WorldBuilder. Address Issue #772.

@github-actions
Copy link

github-actions bot commented Dec 11, 2024

Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.213 ± 0.011 (s=361) 1.213 ± 0.010 (s=383) -0.2% .. +0.2%
Slab interpolation curved simple none 1.212 ± 0.010 (s=374) 1.213 ± 0.014 (s=371) -0.2% .. +0.3%
Spherical slab interpolation simple none 1.227 ± 0.009 (s=363) 1.227 ± 0.010 (s=373) -0.2% .. +0.2%
Slab interpolation simple curved CMS 1.269 ± 0.015 (s=366) 1.253 ± 0.013 (s=350) -1.6% .. -1.0%
Spherical slab interpolation simple CMS 1.638 ± 0.015 (s=278) 1.639 ± 0.014 (s=274) -0.2% .. +0.3%
Spherical fault interpolation simple none 1.230 ± 0.011 (s=360) 1.230 ± 0.011 (s=374) -0.2% .. +0.2%
Cartesian min max surface 2.737 ± 0.029 (s=171) 2.734 ± 0.023 (s=161) -0.5% .. +0.2%
Spherical min max surface 7.720 ± 0.079 (s=65) 7.731 ± 0.083 (s=54) -0.5% .. +0.8%

Copy link
Member

@MFraters MFraters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this pull request! Could you move point 3 to the first position? It is always good to begin with updating you system before doing anything else (especially on WSL it seems).

I am still not sure about why libopenmpi-dev is needed, and that most likely has more to do with the detection through cmake. But that would require a bit more investigation, so for now I think it is fine to just recommend to install it.

@alanjyu
Copy link
Contributor Author

alanjyu commented Dec 11, 2024

Done!

Copy link
Member

@MFraters MFraters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good now!

@MFraters MFraters merged commit 0db874e into GeodynamicWorldBuilder:main Dec 11, 2024
62 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants