Add the first draft of the code structure. #805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Thank you for the review, @MFraters . I addressed your suggestions in the recent commit. |
MFraters
approved these changes
Jan 21, 2025
Member
MFraters
left a comment
MFraters
left a comment
There was a problem hiding this comment.
One small comment, otherwise good to go
| ``` | ||
| The main file that is responsible for creating and accessing the GWB world is `source/world_builder/world.cc`. When creating a new GWB world it uses the parameterizations from the worldbuilder (`*.wb`) input file. External programs, such as `gwb-dat` or `gwb-grid` or other software such as ASPECT or SEPRAN, can then use the provided interfaces to ask about certain properties (e.g. temperature, composition) on any location. | ||
|
|
||
| GWB determines where a given point lies in the World amongst the specified tectonic features. This happens mostly through utility functions, which computes the distance of point from a feature. These and several other utility functions are defined in the `source/world_builder/utilities.cc`. |
Member
There was a problem hiding this comment.
Suggested change
| GWB determines where a given point lies in the World amongst the specified tectonic features. This happens mostly through utility functions, which computes the distance of point from a feature. These and several other utility functions are defined in the `source/world_builder/utilities.cc`. | |
| GWB determines where a given point lies in the World amongst the specified tectonic features. This happens mostly through utility functions, which compute the distance of point from a feature. These and several other utility functions are defined in the `source/world_builder/utilities.cc`. |
|
Address suggestions from the PR. Grammar fix.
alarshi
force-pushed
the
add-code-structure
branch
from
e01ff7c to
dc40a30
Compare
Contributor
Author
|
Thank you for the review! I addressed your comments in the latest commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #791 , but to the current remote :)