Skip to content

Conversation

@nredick
Copy link
Contributor

@nredick nredick commented Jul 2, 2025

CMake 2.8 has been deprecated, resulting in failing build. Update to 3.5

> build % cmake . 
CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

  Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.


-- Configuring incomplete, errors occurred!

Copy link
Member

@MFraters MFraters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this pull request!

I do have to note that there are a lot of unrelated lines changes in this pull request. Normally the spelling fixes for example would go into a separate pull request. You are also changing the spaces of many lines. Normally I would ask you to revert this, but looking at them they seem to make sense so I will let it pass for this time. I suspect they are changed automatically by your editor, so I would like to ask you to turn that off in the future. The reason for this is that editors may have slightly different conventions, which may lead to the same unrelated lines being changed back and forth between pull request. What probably should happen is that the indent script should be extended to these files as well.

Anyway, thanks for the fixes!

@MFraters MFraters merged commit 006bead into GeodynamicWorldBuilder:main Jul 3, 2025
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants