Fix macOS arm64 builds: add SIMD guard and qd archive rebuild#42
Open
shauryasingh310-ops wants to merge 1 commit into
Open
Fix macOS arm64 builds: add SIMD guard and qd archive rebuild#42shauryasingh310-ops wants to merge 1 commit into
shauryasingh310-ops wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix macOS arm64 builds: header ordering, SIMD guard, and qd archive rebuild
Resolves macOS Apple Silicon (arm64) build failures that occur when system lp_solve headers or stale qd artifacts exist.
Changes:
Add ARM64 guard for x86 SIMD intrinsics (src/external/PackedCSparse/FloatArray.h)
#include <immintrin.h>with#ifdef __x86_64__to prevent compilation errors on ARM64Force qd archive rebuild for correct architecture (src/external/PackedCSparse/qd/Makefile)
-march=nativeflag (prevents architecture-specific optimization)cleandependency tolibqd.atarget to ensure rebuild with correct architecturePrioritize vendored headers (src/Makevars, src/Makevars.win)
Result:
R CMD INSTALL .now succeeds on macOS arm64 even if system lp_solve is installed or tree was previously built under different architecture.